Bug 1635817 [wpt PR 23424] - Revert "[FlexNG] Make ComputeMinMaxSizes cache more precise.", a=testonly
authorBalazs Engedy <engedy@chromium.org>
Wed, 13 May 2020 09:42:50 +0000
changeset 531093 cd756e9a2e5bbbb42944dacbd2b89c9346204a1e
parent 531092 176a81670e50110427d1fe971b9f029658a55d49
child 531094 4bd3b8a7521011a9e0b6943ba7f8dee4071f493d
push id37435
push userapavel@mozilla.com
push dateWed, 20 May 2020 15:28:23 +0000
treeherdermozilla-central@5415da14ec9a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1635817, 23424, 845235, 2165676, 765797, 2184130, 765919
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1635817 [wpt PR 23424] - Revert "[FlexNG] Make ComputeMinMaxSizes cache more precise.", a=testonly Automatic update from web-platform-tests Revert "[FlexNG] Make ComputeMinMaxSizes cache more precise." This reverts commit 044aeb3ed3364905cc185d67eb947c7ca3c13741. Reason for revert: Use-of-uninitialized-value. https://test-results.appspot.com/data/layout_results/WebKit_Linux_MSAN/5663/blink_web_tests/layout-test-results/results.html Original change's description: > [FlexNG] Make ComputeMinMaxSizes cache more precise. > > Previously our cache was imprecise, we recalculate our min/max sizes > when we didn't strictly need to, as we didn't know if we'd have a > %-block-size replaced element beneath us. > > This patch changes ComputeMinMaxSizes to return a MinMaxSizesResult > (instead of just MinMaxSizes). This contains an additional bit of > information to indicate if this sub-tree depended on the %-block-size > given to it. > > For most things, this will return false. For legacy layout roots we > always assume that they have children which depend on the %-block-size > (and why we initialize: > intrinsic_logical_widths_depends_on_percentage_block_size_ to true). > > Along with this change, the cache changes in the following way: > - We store an addition bit of information on LayoutBox to store the bit > of information from ComputeMinMaxSizes. > - We calculate the %-block-size for our children up-front, this means > each of the algorithms don't have to do this. > - With these changes, the cache can now hit, when the %-block-size > given to us changes. > > \o/ > > Bug: 845235 > Change-Id: I93504721dbdd13bef58917b1fab2cabbcd1ce51e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165676 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#765797} TBR=cbiesinger@chromium.org,dgrogan@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org Change-Id: I9e5312e4a919fedbdc2cfd08e50a5f8b188e7a25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184130 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#765919} -- wpt-commits: b575c96e10e551afd314ace039360d3577276da9 wpt-pr: 23424
testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-dynamic-009.html
testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-dynamic-010.html
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-dynamic-009.html
+++ /dev/null
@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<link rel="help" href="https://drafts.csswg.org/css-sizing-3/#intrinsic">
-<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
-<meta name="assert" content="This test checks that a dynamic change in the height of an element calculates the intrinsic min/max size correctly when a replaced element is present."/>
-<p>Test passes if there is a filled green square.</p>
-<div id="target" style="float: left; background: green; line-height: 0;">
-  <span style="display: inline-block; height: 100%;">
-    <canvas width="1" height="1" style="height: 100%;"></canvas>
-  </div>
-</div>
-<script>
-  document.body.offsetTop;
-  document.getElementById('target').style.height = '100px';
-</script>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-sizing/intrinsic-percent-replaced-dynamic-010.html
+++ /dev/null
@@ -1,16 +0,0 @@
-<!DOCTYPE html>
-<link rel="help" href="https://drafts.csswg.org/css-sizing-3/#intrinsic">
-<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
-<meta name="assert" content="This test checks that a dynamic change in the height of an element calculates the intrinsic min/max size correctly when a replaced element is present."/>
-<p>Test passes if there is a filled green square.</p>
-<div id="target" style="float: left; background: green; color: transparent;">
-  <span>
-    <div style="float: left; height: 100%;">
-      <canvas width="1" height="1" style="height: 100%;"></canvas>
-    </div>
-  </span>
-</div>
-<script>
-  document.body.offsetTop;
-  document.getElementById('target').style.height = '100px';
-</script>