Bug 1476818 - Choose right add-on icon size for browserAction in the Overflow Menu r=mixedpuppy
authorOriol Brufau <oriol-bugzilla@hotmail.com>
Thu, 19 Jul 2018 01:39:42 +0200
changeset 427489 ccee0cdce495c9269db8f22b4261b82985488964
parent 427488 d22727e8db06829fa086a23ced8740a42882a898
child 427490 b5b413fbb173a909ab5d2e7e808ee8162d5e5b96
push id34306
push usercsabou@mozilla.com
push dateFri, 20 Jul 2018 21:41:18 +0000
treeherdermozilla-central@d6a5e8aea651 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmixedpuppy
bugs1476818
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476818 - Choose right add-on icon size for browserAction in the Overflow Menu r=mixedpuppy MozReview-Commit-ID: J8J4g1jYPfQ
browser/components/extensions/parent/ext-browserAction.js
--- a/browser/components/extensions/parent/ext-browserAction.js
+++ b/browser/components/extensions/parent/ext-browserAction.js
@@ -481,20 +481,19 @@ this.browserAction = class extends Exten
         --webextension-${name}: url("${getIcon(icon, "default")}");
         --webextension-${name}-light: url("${getIcon(icon, "light")}");
         --webextension-${name}-dark: url("${getIcon(icon, "dark")}");
       `;
     };
 
     let icon16 = IconDetails.getPreferredIcon(icons, this.extension, 16).icon;
     let icon32 = IconDetails.getPreferredIcon(icons, this.extension, 32).icon;
-    let icon64 = IconDetails.getPreferredIcon(icons, this.extension, 64).icon;
     return `
-      ${getStyle("menupanel-image", icon32)}
-      ${getStyle("menupanel-image-2x", icon64)}
+      ${getStyle("menupanel-image", icon16)}
+      ${getStyle("menupanel-image-2x", icon32)}
       ${getStyle("toolbar-image", icon16)}
       ${getStyle("toolbar-image-2x", icon32)}
     `;
   }
 
   /**
    * Update the toolbar button for a given window.
    *