bug 379439 - When closing error console: assertion "XPConnect is being called on a scope without a 'Components' property!"add matching removeController() call to the binding's destructor.r=mano
authorasqueella@gmail.com
Wed, 02 May 2007 05:23:59 -0700
changeset 996 cce103d0ebb05aa59e0a683b38b4a0ed03ecd700
parent 995 8c1f558c494d0fd1afaafe1de7711e5c4b5e7adc
child 997 14e09aa3c540e1f568170e6cca2fcaadd354bee8
push id1
push userbsmedberg@mozilla.com
push dateThu, 20 Mar 2008 16:49:24 +0000
treeherdermozilla-central@61007906a1f8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmano
bugs379439
milestone1.9a5pre
bug 379439 - When closing error console: assertion "XPConnect is being called on a scope without a 'Components' property!"add matching removeController() call to the binding's destructor.r=mano
toolkit/components/console/content/consoleBindings.xml
--- a/toolkit/components/console/content/consoleBindings.xml
+++ b/toolkit/components/console/content/consoleBindings.xml
@@ -97,16 +97,17 @@
           this.appendInitialItems();
           window.controllers.insertControllerAt(0, this._controller);
         ]]></body>
       </method>
 
       <method name="destroy">
         <body><![CDATA[
           this.mCService.unregisterListener(this.mConsoleListener);
+          window.controllers.removeController(this._controller);
         ]]></body>
       </method>
 
       <method name="appendInitialItems">
         <body><![CDATA[
           var out = {}; // Throwaway references to support 'out' parameters.
           this.mCService.getMessageArray(out, {});
           var messages = out.value;