Bug 1311925 - Remove yellow highlight from search boxes. r=gl
authorTim Nguyen <ntim.bugs@gmail.com>
Thu, 03 Nov 2016 19:18:16 +0000
changeset 321065 cb4ab44839fddd59d37cd67c51aa8954998f9435
parent 321064 9601d282b06bb5f22d855b383a895b51275a3143
child 321066 0797f7f58f2287952815196dece545faf5af14a1
push id30915
push userphilringnalda@gmail.com
push dateSat, 05 Nov 2016 03:42:29 +0000
treeherdermozilla-central@a7c654513f2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1311925
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1311925 - Remove yellow highlight from search boxes. r=gl MozReview-Commit-ID: Bxu6uMKw7LM
devtools/client/inspector/inspector-search.js
devtools/client/themes/common.css
--- a/devtools/client/inspector/inspector-search.js
+++ b/devtools/client/inspector/inspector-search.js
@@ -107,21 +107,19 @@ InspectorSearch.prototype = {
       this.searchBox.classList.add("devtools-style-searchbox-no-match");
       this.emit("search-result");
     }
   }),
 
   _onInput: function () {
     if (this.searchBox.value.length === 0) {
       this.searchClearButton.hidden = true;
-      this.searchBox.removeAttribute("filled");
       this._onSearch();
     } else {
       this.searchClearButton.hidden = false;
-      this.searchBox.setAttribute("filled", true);
     }
   },
 
   _onKeyDown: function (event) {
     if (event.keyCode === KeyCodes.DOM_VK_RETURN) {
       this._onSearch(event.shiftKey);
     }
 
--- a/devtools/client/themes/common.css
+++ b/devtools/client/themes/common.css
@@ -629,17 +629,16 @@ checkbox:-moz-focusring {
   padding-inline-end: 0;
 }
 
 .devtools-rule-searchbox {
   -moz-box-flex: 1;
   width: 100%;
 }
 
-.devtools-searchinput:-moz-any([filled],.filled),
 .devtools-filterinput:-moz-any([filled],.filled) {
   background-color: var(--searchbox-background-color);
   border-color: var(--searchbox-border-color);
 }
 
 .devtools-style-searchbox-no-match {
   background-color: var(--searcbox-no-match-background-color) !important;
   border-color: var(--searcbox-no-match-border-color) !important;