Bug 1483440 - Part 4 - Don't send purge-domain-data when cleaning up site preferences. r=baku
authorJohann Hofmann <jhofmann@mozilla.com>
Thu, 17 Jan 2019 17:41:30 +0000
changeset 454312 cb1a55c678c1bad3e9e6634f7222186ece14e4b3
parent 454311 4b57fb875b4293ad718447795925ecc6df31a0ae
child 454313 a27f8c7557d4eefc9ed75192aff5eba3d1b80d6f
push id35392
push userncsoregi@mozilla.com
push dateThu, 17 Jan 2019 21:53:28 +0000
treeherdermozilla-central@24982570fc83 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1483440
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1483440 - Part 4 - Don't send purge-domain-data when cleaning up site preferences. r=baku As far as I can tell this was only ever done to give legacy add-ons the chance to clean up user data and isn't needed anymore (and had the strange side effect that e.g. localStorage was cleared when removing the site zoom settings). Differential Revision: https://phabricator.services.mozilla.com/D16463
toolkit/components/cleardata/ClearDataService.js
--- a/toolkit/components/cleardata/ClearDataService.js
+++ b/toolkit/components/cleardata/ClearDataService.js
@@ -640,19 +640,16 @@ const PermissionsCleaner = {
 
 const PreferencesCleaner = {
   deleteByHost(aHost, aOriginAttributes) {
     return new Promise((aResolve, aReject) => {
       let cps2 = Cc["@mozilla.org/content-pref/service;1"]
                    .getService(Ci.nsIContentPrefService2);
       cps2.removeBySubdomain(aHost, null, {
         handleCompletion: aReason => {
-          // Notify other consumers, including extensions
-          Services.obs.notifyObservers(null, "browser:purge-domain-data",
-                                       aHost);
           if (aReason === cps2.COMPLETE_ERROR) {
             aReject();
           } else {
             aResolve();
           }
         },
         handleError() {},
       });