Bug 1404326 - Fixing comments in MediaRecorder.cpp, r=padenot
authorAndrea Marchesini <amarchesini@mozilla.com>
Fri, 29 Sep 2017 16:11:47 +0200
changeset 383807 ca9caeade4d6937271172a9d45152db35a351632
parent 383806 87438bd3387b1bf1940f91e0baec60b9d62b4a0c
child 383808 263c2de9cce58f2d160f651ece58fe50cc6bb886
push id32602
push userkwierso@gmail.com
push dateFri, 29 Sep 2017 21:47:40 +0000
treeherdermozilla-central@57f68296c350 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1404326
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1404326 - Fixing comments in MediaRecorder.cpp, r=padenot
dom/media/MediaRecorder.cpp
--- a/dom/media/MediaRecorder.cpp
+++ b/dom/media/MediaRecorder.cpp
@@ -153,21 +153,21 @@ NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(
 NS_INTERFACE_MAP_END_INHERITING(DOMEventTargetHelper)
 
 NS_IMPL_ADDREF_INHERITED(MediaRecorder, DOMEventTargetHelper)
 NS_IMPL_RELEASE_INHERITED(MediaRecorder, DOMEventTargetHelper)
 
 /**
  * Session is an object to represent a single recording event.
  * In original design, all recording context is stored in MediaRecorder, which causes
- * a problem if someone calls MediaRecoder::Stop and MedaiRecorder::Start quickly.
+ * a problem if someone calls MediaRecorder::Stop and MediaRecorder::Start quickly.
  * To prevent blocking main thread, media encoding is executed in a second thread,
  * named as Read Thread. For the same reason, we do not wait Read Thread shutdown in
- * MediaRecorder::Stop. If someone call MediaRecoder::Start before Read Thread shutdown,
- * the same recording context in MediaRecoder might be access by two Reading Threads,
+ * MediaRecorder::Stop. If someone call MediaRecorder::Start before Read Thread shutdown,
+ * the same recording context in MediaRecorder might be access by two Reading Threads,
  * which cause a  problem.
  * In the new design, we put recording context into Session object, including Read
  * Thread.  Each Session has its own recording context and Read Thread, problem is been
  * resolved.
  *
  * Life cycle of a Session object.
  * 1) Initialization Stage (in main thread)
  *    Setup media streams in MSG, and bind MediaEncoder with Source Stream when mStream is available.
@@ -1040,17 +1040,17 @@ private:
           return ShutdownPromise::CreateAndReject(false, __func__);
         });
     }
 
     return mShutdownPromise;
   }
 
 private:
-  // Hold reference to MediaRecoder that ensure MediaRecorder is alive
+  // Hold reference to MediaRecorder that ensure MediaRecorder is alive
   // if there is an active session. Access ONLY on main thread.
   RefPtr<MediaRecorder> mRecorder;
 
   // Stream currently recorded.
   RefPtr<DOMMediaStream> mMediaStream;
 
   // Tracks currently recorded. This should be a subset of mMediaStream's track
   // set.