Bug 1352355 [wpt PR 14464] - [Gecko Bug 1352355] Enable storing and updating mozleak metadata in wpt ini, a=testonly
authormoz-wptsync-bot <wptsync@mozilla.com>
Fri, 01 Feb 2019 13:34:04 +0000
changeset 458180 ca1061daf2eab8c3e115b39ef37458c7d830ef41
parent 458179 c55f99389f89876a753c78ac6133c053c20a2bbf
child 458181 b98eb771f0e0e4c327303fa6346fa3a27e3c9c10
push id35518
push useropoprus@mozilla.com
push dateFri, 08 Feb 2019 09:55:14 +0000
treeherdermozilla-central@3a3e393396f4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1352355, 14464
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1352355 [wpt PR 14464] - [Gecko Bug 1352355] Enable storing and updating mozleak metadata in wpt ini, a=testonly Automatic update from web-platform-tests Enable storing and updating mozleak metadata in wpt ini This adds two new properties to wpt metadata files: mozleak-allowed - This is a list of the form [process-name:object name], which indicates objects that may be leaked in that specific process. Automatic updates that find a leak may add that object to this list. mozleak-threshold - This is a list (but conceptually a map) of [process-name: threshold bytes], indicating a threshold below which leaks will not cause a test failure. This number is updated by setting it to the observed value for a process. Depends on D12410 Differential Revision: https://phabricator.services.mozilla.com/D12411 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1352355 gecko-commit: 02e4dbfecbc426e118199e4ce140db13814aaf7a gecko-integration-branch: central gecko-reviewers: ato -- Enable leak checks by default in wpt debug builds Depends on D12412 Differential Revision: https://phabricator.services.mozilla.com/D12413 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1352355 gecko-commit: f3f4ea333cc4268ca48cf4eef9f821c490401544 gecko-integration-branch: central gecko-reviewers: ato -- Fix use of wpt settings in firefox Browser The settngs() method is called to get a list of session-level settings that should be applied when running a test. If those settings differ from the ones applied to the previous test then we have to restart the browser. But if we set the session on the class in the settings method then at shutdown time we'll have incorrect settings. This is important for things like leak checking where the values affect the shutdown process. So instead ensure that we only set the settings on the class during startup. Depends on D12414 Differential Revision: https://phabricator.services.mozilla.com/D13512 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1352355 gecko-commit: 36c4c80ddc1a12665af8cbcaef716e384caab99e gecko-integration-branch: central gecko-reviewers: ato -- Fix thresholds in leak update tests -- wpt-commits: d18e0a52f638ddd4953cdde8ac373f1d611f70cd, 69e6b3e51409c490b425596ac9b7c08a7382e3ae, 44a02fa6eb5173e685c20362ce1409fc4fbe907d, 53fa0b78c29165ceacf478f31add85c6e790f50a wpt-pr: 14464
testing/web-platform/tests/tools/wptrunner/wptrunner/tests/test_update.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/tests/test_update.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/tests/test_update.py
@@ -620,17 +620,17 @@ def test_update_leak_total_0():
                                           "bytes": 100,
                                           "threshold": 0,
                                           "objects": []})])
 
     updated = update(tests, log_0)
     new_manifest = updated[0][1]
 
     assert not new_manifest.is_empty
-    assert new_manifest.get("leak-threshold") == ['default:110']
+    assert new_manifest.get("leak-threshold") == ['default:51200']
 
 
 def test_update_leak_total_1():
     test_id = "/path/to/test.htm"
     dir_id = "path/to/__dir__"
     tests = [("path/to/test.htm", [test_id], "testharness", ""),
              ("path/to/__dir__", [dir_id], None, "")]
 
@@ -673,17 +673,17 @@ leak-total: 100""")]
                                           "bytes": 1000,
                                           "threshold": 100,
                                           "objects": []})])
 
     updated = update(tests, log_0)
     new_manifest = updated[0][1]
 
     assert not new_manifest.is_empty
-    assert new_manifest.get("leak-threshold") == ['default:1100']
+    assert new_manifest.get("leak-threshold") == ['default:51200']
 
 
 def test_update_leak_total_4():
     test_id = "/path/to/test.htm"
     dir_id = "path/to/__dir__"
     tests = [("path/to/test.htm", [test_id], "testharness", ""),
              ("path/to/__dir__", [dir_id], None, """
 leak-total: 110""")]