Bug 1444940 [wpt PR 9922] - [ServiceWorker] Fix an incorrect usage of assert_equals() in wpt test, a=testonly
authorHan Leon <leon.han@intel.com>
Mon, 26 Mar 2018 15:37:32 +0000
changeset 411280 c9bb88bd5251e143900648b23e96416686744f31
parent 411279 7ec8a0f2b4173c7bbd730cbfed9dae6ae1c8eed6
child 411281 8bf57a1258c4bf6cea19672c381ee9d4a4a3d2c2
push id33749
push usercsabou@mozilla.com
push dateMon, 02 Apr 2018 10:18:51 +0000
treeherdermozilla-central@c44f60c43432 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1444940, 955282, 542048
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1444940 [wpt PR 9922] - [ServiceWorker] Fix an incorrect usage of assert_equals() in wpt test, a=testonly Automatic update from web-platform-tests[ServiceWorker] Fix an incorrect usage of assert_equals() in wpt test This prototype is 'assert_equals(actual, expected, description)', we should pass 'actual' and 'expected' in order, to make the failure message be reasonable. This CL just fixes external/wpt/service-workers/service-worker/navigate-window.https.html. BUG= Change-Id: Ic11ec67f27f7a9a5ae289ddda4362af72b4737d4 Reviewed-on: https://chromium-review.googlesource.com/955282 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542048} wpt-commits: 0de8b996b14f080180b56a6999fc57d8a4a94898 wpt-pr: 9922 wpt-commits: 0de8b996b14f080180b56a6999fc57d8a4a94898 wpt-pr: 9922
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/service-workers/service-worker/navigate-window.https.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -591102,17 +591102,17 @@
    "88dd84637f82e942e5efe6caafb99a18df602353",
    "testharness"
   ],
   "service-workers/service-worker/multiple-update.https.html": [
    "1cb6912164a02808f455538ea292f288b2f12ace",
    "testharness"
   ],
   "service-workers/service-worker/navigate-window.https.html": [
-   "0499d4489276c2a933b79e47f1de591f467f42aa",
+   "4b481c60520981f5f5791344cd78d638412b4ecb",
    "testharness"
   ],
   "service-workers/service-worker/navigation-preload/broken-chunked-encoding.https.html": [
    "4953b0c2e9c0a0a02b285ca89b69947798804e58",
    "testharness"
   ],
   "service-workers/service-worker/navigation-preload/chunked-encoding.https.html": [
    "2d77619348ca1ed77fd9f2b29412a9b5452607d6",
--- a/testing/web-platform/tests/service-workers/service-worker/navigate-window.https.html
+++ b/testing/web-platform/tests/service-workers/service-worker/navigate-window.https.html
@@ -89,19 +89,19 @@ function validate_window(win, url, opts)
 
         assert_equals(resultList.length, expected.length,
                       'expected number of clients');
 
         expected.sort(compare_urls);
         resultList.sort(compare_urls);
 
         for (var i = 0; i < resultList.length; ++i) {
-          assert_equals(expected[i].url, resultList[i].url,
+          assert_equals(resultList[i].url, expected[i].url,
                         'client should have expected url');
-          assert_equals(expected[i].frameType, resultList[i].frameType,
+          assert_equals(resultList[i].frameType, expected[i].frameType,
                         'client should have expected frame type');
         }
         return win;
       })
 }
 
 promise_test(function(t) {
     var worker = BASE_URL + 'resources/navigate-window-worker.js';