Bug 1117746 - Share asset is intermittently missing from recent nightlies r=rnewman
authorMark Finkle <mfinkle@mozilla.com>
Mon, 05 Jan 2015 12:18:45 -0500
changeset 222084 c98966220fd653f664a9cefc1dc8e349a1c5f15b
parent 222083 359485b8b583f2f43874d631bd77786325669e6c
child 222085 010c93a343d2f1ad0b18ce0906e867c867b0275b
push id28057
push userkwierso@gmail.com
push dateTue, 06 Jan 2015 01:09:53 +0000
treeherdermozilla-central@2a193b7f395c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrnewman
bugs1117746
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1117746 - Share asset is intermittently missing from recent nightlies r=rnewman
mobile/android/base/menu/GeckoMenuItem.java
--- a/mobile/android/base/menu/GeckoMenuItem.java
+++ b/mobile/android/base/menu/GeckoMenuItem.java
@@ -439,17 +439,19 @@ public class GeckoMenuItem implements Me
     @Override
     public MenuItem setTitleCondensed(CharSequence title) {
         mTitleCondensed = title;
         return this;
     }
 
     @Override
     public MenuItem setVisible(boolean visible) {
-        if (mVisible != visible) {
+        // Action views are not normal menu items and visibility can get out
+        // of sync unless we dispatch whenever required.
+        if (isActionItem() || mVisible != visible) {
             mVisible = visible;
             if (mShouldDispatchChanges) {
                 mMenu.onItemChanged(this);
             } else {
                 mDidChange = true;
             }
         }
         return this;