Bug 1790299 - Make test more similar between xul/non-xul. r=dholbert
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 02 Oct 2022 06:08:54 +0000
changeset 636766 c949d841e3e9f4f1b9a34c1e7ebb958fd8e04585
parent 636765 473e72a1c3a330d7529fe7620824fb707044b0bc
child 636767 13595ac6b06fe3455f1c8e5bd09333b78384def4
push id40280
push usernfay@mozilla.com
push dateSun, 02 Oct 2022 09:32:40 +0000
treeherdermozilla-central@c949d841e3e9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1790299
milestone107.0a1
first release with
nightly linux32
c949d841e3e9 / 107.0a1 / 20221002093240 / files
nightly linux64
c949d841e3e9 / 107.0a1 / 20221002093240 / files
nightly win32
c949d841e3e9 / 107.0a1 / 20221002093240 / files
nightly win64
c949d841e3e9 / 107.0a1 / 20221002093240 / files
nightly mac
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly win32
nightly win64
Bug 1790299 - Make test more similar between xul/non-xul. r=dholbert This doesn't have any behavior change, test-only. I wrote this while debugging the previous patches. Modern flexbox respects width/height over flex, which is not true for legacy flexbox, so this makes the box sizes match, effectively, which makes it easier to compare to figure out regressions. Differential Revision: https://phabricator.services.mozilla.com/D157913
layout/xul/test/test_splitter.xhtml
--- a/layout/xul/test/test_splitter.xhtml
+++ b/layout/xul/test/test_splitter.xhtml
@@ -99,33 +99,33 @@ XUL <splitter> collapsing tests
       await runTests(false, "ltr-flex-splitter");
       await runTests(true, "rtl-flex-splitter");
       SimpleTest.finish();
     }
 
     addLoadEvent(function() {SimpleTest.executeSoon(runAllTests);});
    ]]></script>
 
-  <hbox style="display: none; max-width: 200px; height: 300px; direction: ltr;">
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+  <hbox style="display: none; width: 200px; height: 300px; direction: ltr;">
+    <vbox style="height: 300px;" flex="1"/>
     <splitter id="ltr-splitter" width="5"/>
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+    <vbox style="height: 300px;" flex="1"/>
   </hbox>
 
-  <hbox style="display: none; max-width: 200px; height: 300px; direction: rtl;">
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+  <hbox style="display: none; width: 200px; height: 300px; direction: rtl;">
+    <vbox style="height: 300px;" flex="1"/>
     <splitter id="rtl-splitter" width="5"/>
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+    <vbox style="height: 300px;" flex="1"/>
   </hbox>
 
-  <hbox style="display: none; max-width: 200px; height: 300px; direction: ltr; -moz-box-layout: flex">
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+  <hbox style="display: none; width: 200px; height: 300px; direction: ltr; -moz-box-layout: flex">
+    <vbox style="height: 300px;" flex="1"/>
     <splitter id="ltr-flex-splitter" width="5"/>
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+    <vbox style="height: 300px;" flex="1"/>
   </hbox>
 
-  <hbox style="display: none; max-width: 200px; height: 300px; direction: rtl; -moz-box-layout: flex">
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+  <hbox style="display: none; width: 200px; height: 300px; direction: rtl; -moz-box-layout: flex">
+    <vbox style="height: 300px;" flex="1"/>
     <splitter id="rtl-flex-splitter" width="5"/>
-    <vbox style="width: 100px; height: 300px;" flex="1"/>
+    <vbox style="height: 300px;" flex="1"/>
   </hbox>
 
 </window>