Bug 1318091 - Disable failing android gtests; r=bc
authorGeoff Brown <gbrown@mozilla.com>
Mon, 08 Apr 2019 20:58:21 +0000
changeset 468429 c87d5720c98201317c94bf8655a07f32fb188e00
parent 468428 759745dda57e472022902510ee408e7f30b582e0
child 468430 5da5b22bc3a74a98ec3cc23712199a0fd0f2ffdc
push id35837
push userrmaries@mozilla.com
push dateTue, 09 Apr 2019 03:43:40 +0000
treeherdermozilla-central@9eb55c9bf557 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbc
bugs1318091
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1318091 - Disable failing android gtests; r=bc Disable gtests observed to fail on Android. Some of these are simple build failures and failures due to file permissions or paths, while other failures are more obscure. Once Android gtests are running on mozilla-central, I will file follow-up bugs inviting teams to investigate the failures and re-enable Android gtests that are important to them. Differential Revision: https://phabricator.services.mozilla.com/D26606
dom/media/gtest/moz.build
dom/media/gtest/mp4_demuxer/moz.build
gfx/layers/apz/test/gtest/moz.build
gfx/tests/gtest/moz.build
image/test/gtest/moz.build
layout/base/gtest/moz.build
media/libcubeb/gtest/moz.build
media/mtransport/test/moz.build
netwerk/test/gtest/moz.build
netwerk/test/gtest/parse-ftp/moz.build
toolkit/components/telemetry/tests/gtest/moz.build
toolkit/profile/gtest/moz.build
tools/profiler/tests/gtest/moz.build
xpcom/tests/gtest/moz.build
--- a/dom/media/gtest/moz.build
+++ b/dom/media/gtest/moz.build
@@ -19,49 +19,53 @@ UNIFIED_SOURCES += [
     'TestAudioCompactor.cpp',
     'TestAudioMixer.cpp',
     'TestAudioPacketizer.cpp',
     'TestAudioSegment.cpp',
     'TestAudioTrackEncoder.cpp',
     'TestBitWriter.cpp',
     'TestBlankVideoDataCreator.cpp',
     'TestBufferReader.cpp',
-    'TestCDMStorage.cpp',
     'TestDataMutex.cpp',
     'TestDriftCompensation.cpp',
-    'TestGMPCrossOrigin.cpp',
-    'TestGMPRemoveAndDelete.cpp',
     'TestGMPUtils.cpp',
     'TestGroupId.cpp',
     'TestIntervalSet.cpp',
-    'TestMediaDataDecoder.cpp',
-    'TestMediaDataEncoder.cpp',
     'TestMediaEventSource.cpp',
     'TestMediaMIMETypes.cpp',
-    'TestMP3Demuxer.cpp',
-    'TestMP4Demuxer.cpp',
     'TestOpusParser.cpp',
     'TestRust.cpp',
     'TestVideoSegment.cpp',
     'TestVideoUtils.cpp',
-    'TestVPXDecoding.cpp',
-    'TestWebMBuffered.cpp',
 ]
 
 if CONFIG['MOZ_WEBM_ENCODER']:
     UNIFIED_SOURCES += [
         'TestVideoTrackEncoder.cpp',
         'TestWebMWriter.cpp',
         'YUVBufferGenerator.cpp',
     ]
     LOCAL_INCLUDES += [
         '/gfx/2d/',
     ]
 
-if CONFIG['MOZ_WEBRTC']:
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestCDMStorage.cpp',
+        'TestGMPCrossOrigin.cpp',
+        'TestGMPRemoveAndDelete.cpp',
+        'TestMediaDataDecoder.cpp',
+        'TestMediaDataEncoder.cpp',
+        'TestMP3Demuxer.cpp',
+        'TestMP4Demuxer.cpp',
+        'TestVPXDecoding.cpp',
+        'TestWebMBuffered.cpp',
+    ]
+
+if CONFIG['MOZ_WEBRTC'] and CONFIG['OS_TARGET'] != 'Android':
     UNIFIED_SOURCES += [
         'TestAudioDeviceEnumerator.cpp',
         'TestVideoFrameConverter.cpp',
     ]
 
 TEST_HARNESS_FILES.gtest += [
     '../test/gizmo-frag.mp4',
     '../test/gizmo.mp4',
--- a/dom/media/gtest/mp4_demuxer/moz.build
+++ b/dom/media/gtest/mp4_demuxer/moz.build
@@ -1,20 +1,21 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 Library('mp4_demuxer_gtest')
 
-SOURCES += [
-    'TestInterval.cpp',
-    'TestParser.cpp',
-]
+if CONFIG['OS_TARGET'] != 'Android':
+    SOURCES += [
+        'TestInterval.cpp',
+        'TestParser.cpp',
+    ]
 
 TEST_HARNESS_FILES.gtest += [
     'test_case_1156505.mp4',
     'test_case_1181213.mp4',
     'test_case_1181215.mp4',
     'test_case_1181220.mp4',
     'test_case_1181223.mp4',
     'test_case_1181719.mp4',
@@ -43,17 +44,19 @@ TEST_HARNESS_FILES.gtest += [
     'test_case_1395244.mp4',
     'test_case_1410565.mp4',
     'test_case_1513651-2-sample-description-entries.mp4',
     'test_case_1519617-cenc-init-with-track_id-0.mp4',
     'test_case_1519617-track2-trafs-removed.mp4',
     'test_case_1519617-video-has-track_id-0.mp4',
 ]
 
-UNIFIED_SOURCES += ['TestMP4.cpp',]
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += ['TestMP4.cpp',]
+
 TEST_HARNESS_FILES.gtest += [
     '../../test/street.mp4',
 ]
 LOCAL_INCLUDES += [
     '../../mp4',
     '/toolkit/components/telemetry/tests/gtest',
 ]
 
--- a/gfx/layers/apz/test/gtest/moz.build
+++ b/gfx/layers/apz/test/gtest/moz.build
@@ -1,27 +1,31 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 UNIFIED_SOURCES += [
-    'TestBasic.cpp',
     'TestEventRegions.cpp',
-    'TestGestureDetector.cpp',
     'TestHitTesting.cpp',
     'TestInputQueue.cpp',
     'TestPanning.cpp',
-    'TestPinching.cpp',
-    'TestScrollHandoff.cpp',
     'TestSnapping.cpp',
     'TestTreeManager.cpp',
 ]
 
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestBasic.cpp',
+        'TestGestureDetector.cpp',
+        'TestPinching.cpp',
+        'TestScrollHandoff.cpp',
+    ]
+
 include('/ipc/chromium/chromium-config.mozbuild')
 
 LOCAL_INCLUDES += [
     '/gfx/2d',
     '/gfx/layers',
     '/gfx/tests/gtest'  # for TestLayers.h, which is shared with the gfx gtests
 ]
 
--- a/gfx/tests/gtest/moz.build
+++ b/gfx/tests/gtest/moz.build
@@ -8,34 +8,38 @@ UNIFIED_SOURCES += [
     'gfxSurfaceRefCountTest.cpp',
     'MockWidget.cpp',
     'PolygonTestUtils.cpp',
     'TestArena.cpp',
     'TestArrayView.cpp',
     'TestBSPTree.cpp',
     'TestBufferRotation.cpp',
     'TestColorNames.cpp',
-    'TestCompositor.cpp',
-    'TestGfxPrefs.cpp',
     'TestGfxWidgets.cpp',
     'TestJobScheduler.cpp',
     'TestLayers.cpp',
     'TestMoz2D.cpp',
     'TestPolygon.cpp',
     'TestQcms.cpp',
-    'TestRect.cpp',
     'TestRegion.cpp',
     'TestSkipChars.cpp',
     'TestSwizzle.cpp',
-    'TestTextureCompatibility.cpp',
     'TestTextures.cpp',
     'TestTreeTraversal.cpp',
     'TestVsync.cpp',
 ]
 
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestCompositor.cpp',
+        'TestGfxPrefs.cpp',
+        'TestRect.cpp',
+        'TestTextureCompatibility.cpp',
+    ]
+
 UNIFIED_SOURCES += [ '/gfx/2d/unittest/%s' % p for p in [
     'TestBase.cpp',
     'TestBugs.cpp',
     'TestCairo.cpp',
     'TestPoint.cpp',
     'TestScaling.cpp',
 ]]
 
--- a/image/test/gtest/moz.build
+++ b/image/test/gtest/moz.build
@@ -6,31 +6,35 @@
 
 Library('imagetest')
 
 UNIFIED_SOURCES = [
     'Common.cpp',
     'TestADAM7InterpolatingFilter.cpp',
     'TestAnimationFrameBuffer.cpp',
     'TestBlendAnimationFilter.cpp',
-    'TestContainers.cpp',
     'TestCopyOnWrite.cpp',
-    'TestDecoders.cpp',
-    'TestDecodeToSurface.cpp',
     'TestDeinterlacingFilter.cpp',
-    'TestFrameAnimator.cpp',
     'TestLoader.cpp',
-    'TestMetadata.cpp',
     'TestRemoveFrameRectFilter.cpp',
-    'TestSourceBuffer.cpp',
     'TestStreamingLexer.cpp',
-    'TestSurfaceCache.cpp',
     'TestSurfaceSink.cpp',
 ]
 
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestContainers.cpp',
+        'TestDecoders.cpp',
+        'TestDecodeToSurface.cpp',
+        'TestFrameAnimator.cpp',
+        'TestMetadata.cpp',
+        'TestSourceBuffer.cpp',
+        'TestSurfaceCache.cpp',
+    ]
+
 if CONFIG['MOZ_ENABLE_SKIA']:
     UNIFIED_SOURCES += [
         'TestDownscalingFilter.cpp',
         'TestSurfacePipeIntegration.cpp',
     ]
 
 SOURCES += [
     # Can't be unified because it manipulates the preprocessor environment.
--- a/layout/base/gtest/moz.build
+++ b/layout/base/gtest/moz.build
@@ -1,18 +1,20 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-UNIFIED_SOURCES += [
-    'TestAccessibleCaretEventHub.cpp',
-    'TestAccessibleCaretManager.cpp',
-]
+
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestAccessibleCaretEventHub.cpp',
+        'TestAccessibleCaretManager.cpp',
+    ]
 
 # THE MOCK_METHOD2 macro from gtest triggers this clang warning and it's hard
 # to work around, so we just ignore it.
 if CONFIG['CC_TYPE'] == 'clang':
   CXXFLAGS += ['-Wno-inconsistent-missing-override']
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
--- a/media/libcubeb/gtest/moz.build
+++ b/media/libcubeb/gtest/moz.build
@@ -7,17 +7,17 @@
 UNIFIED_SOURCES += [
 #  'test_duplex.cpp', # DISABLED: See bug 1314514.
 #  'test_record.cpp', # DISABLED: See bug 1314514.
 #  'test_overload_callback.cpp', # DISABLED: Times out in automation.
   'test_tone.cpp',
   'test_utils.cpp'
 ]
 
-if CONFIG['MOZ_PULSEAUDIO'] or CONFIG['OS_TARGET'] in ('Darwin', 'WINNT', 'Android'):
+if CONFIG['MOZ_PULSEAUDIO'] or CONFIG['OS_TARGET'] in ('Darwin', 'WINNT'):
   UNIFIED_SOURCES += [
     'test_resampler.cpp',
   ]
 
 if CONFIG['OS_TARGET'] != 'Android':
   UNIFIED_SOURCES += [
     'test_audio.cpp',
     'test_latency.cpp',
--- a/media/mtransport/test/moz.build
+++ b/media/mtransport/test/moz.build
@@ -2,19 +2,24 @@
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 include("/ipc/chromium/chromium-config.mozbuild")
 
 if CONFIG['OS_TARGET'] != 'WINNT':
+
+    if CONFIG['OS_TARGET'] != 'Android':
+        SOURCES += [
+            'ice_unittest.cpp',
+        ]
+
     SOURCES += [
         'buffered_stun_socket_unittest.cpp',
-        'ice_unittest.cpp',
         'multi_tcp_socket_unittest.cpp',
         'nrappkit_unittest.cpp',
         'proxy_tunnel_socket_unittest.cpp',
         'rlogconnector_unittest.cpp',
         'runnable_utils_unittest.cpp',
         'simpletokenbucket_unittest.cpp',
         'sockettransportservice_unittest.cpp',
         'stunserver.cpp',
--- a/netwerk/test/gtest/moz.build
+++ b/netwerk/test/gtest/moz.build
@@ -5,26 +5,30 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 UNIFIED_SOURCES += [
     'TestBufferedInputStream.cpp',
     'TestHeaders.cpp',
     'TestHttpAuthUtils.cpp',
     'TestIsValidIp.cpp',
     'TestMIMEInputStream.cpp',
-    'TestMozURL.cpp',
     'TestPACMan.cpp',
     'TestPartiallySeekableInputStream.cpp',
     'TestProtocolProxyService.cpp',
     'TestReadStreamToString.cpp',
-    'TestServerTimingHeader.cpp',
     'TestStandardURL.cpp',
     'TestURIMutator.cpp',
 ]
 
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestMozURL.cpp',
+        'TestServerTimingHeader.cpp',
+    ]
+
 TEST_HARNESS_FILES.gtest += [
     'urltestdata.json',
 ]
 
 TEST_DIRS += [
     'parse-ftp',
 ]
 
--- a/netwerk/test/gtest/parse-ftp/moz.build
+++ b/netwerk/test/gtest/parse-ftp/moz.build
@@ -1,17 +1,18 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-UNIFIED_SOURCES += [
-    'TestParseFTPList.cpp',
-]
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestParseFTPList.cpp',
+    ]
 
 TEST_HARNESS_FILES.gtest += [
     '3-guess.in',
     '3-guess.out',
     'C-VMold.in',
     'C-VMold.out',
     'C-zVM.in',
     'C-zVM.out',
--- a/toolkit/components/telemetry/tests/gtest/moz.build
+++ b/toolkit/components/telemetry/tests/gtest/moz.build
@@ -8,17 +8,21 @@ Library('telemetrytest')
 
 LOCAL_INCLUDES += [
     '../..',
 ]
 
 UNIFIED_SOURCES = [
     'TelemetryFixture.cpp',
     'TelemetryTestHelpers.cpp',
-    'TestCombinedStacks.cpp',
-    'TestCounters.cpp',
-    'TestEvents.cpp',
-    'TestHistograms.cpp',
-    'TestOrigins.cpp',
-    'TestScalars.cpp'
 ]
 
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestCombinedStacks.cpp',
+        'TestCounters.cpp',
+        'TestEvents.cpp',
+        'TestHistograms.cpp',
+        'TestOrigins.cpp',
+        'TestScalars.cpp'
+    ]
+
 FINAL_LIBRARY = 'xul-gtest'
--- a/toolkit/profile/gtest/moz.build
+++ b/toolkit/profile/gtest/moz.build
@@ -7,14 +7,14 @@
 LOCAL_INCLUDES += [
     '..',
 ]
 
 UNIFIED_SOURCES += [
     'TestProfileLock.cpp',
 ]
 
-if CONFIG['OS_ARCH'] == 'Linux':
+if CONFIG['OS_ARCH'] == 'Linux' and CONFIG['OS_TARGET'] != 'Android':
     UNIFIED_SOURCES += [
         'TestProfileLockRetry.cpp',
     ]
 
 FINAL_LIBRARY = 'xul-gtest'
--- a/tools/profiler/tests/gtest/moz.build
+++ b/tools/profiler/tests/gtest/moz.build
@@ -13,17 +13,18 @@ if (CONFIG['OS_TARGET'] in ('Android', '
     ]
 
 LOCAL_INCLUDES += [
     '/tools/profiler/core',
     '/tools/profiler/gecko',
     '/tools/profiler/lul',
 ]
 
-UNIFIED_SOURCES += [
-    'GeckoProfiler.cpp',
-    'ThreadProfileTest.cpp',
-]
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'GeckoProfiler.cpp',
+        'ThreadProfileTest.cpp',
+    ]
 
 FINAL_LIBRARY = 'xul-gtest'
 
 if CONFIG['CC_TYPE'] in ('clang', 'gcc'):
     CXXFLAGS += ['-Wno-error=shadow']
--- a/xpcom/tests/gtest/moz.build
+++ b/xpcom/tests/gtest/moz.build
@@ -2,21 +2,19 @@
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 UNIFIED_SOURCES += [
     'Helpers.cpp',
     'TestArenaAllocator.cpp',
-    'TestAtoms.cpp',
     'TestAutoPtr.cpp',
     'TestAutoRef.cpp',
     'TestAutoRefCnt.cpp',
-    'TestBase64.cpp',
     'TestCallTemplates.cpp',
     'TestCloneInputStream.cpp',
     'TestCOMPtrEq.cpp',
     'TestCRT.cpp',
     'TestDafsa.cpp',
     'TestEncoding.cpp',
     'TestEscape.cpp',
     'TestEventPriorities.cpp',
@@ -41,36 +39,42 @@ UNIFIED_SOURCES += [
     'TestPriorityQueue.cpp',
     'TestRacingServiceManager.cpp',
     'TestRecursiveMutex.cpp',
     'TestRWLock.cpp',
     'TestSlicedInputStream.cpp',
     'TestSnappyStreams.cpp',
     'TestStateWatching.cpp',
     'TestStorageStream.cpp',
-    'TestStrings.cpp',
     'TestStringStream.cpp',
     'TestSynchronization.cpp',
     'TestTArray.cpp',
     'TestTArray2.cpp',
     'TestTaskQueue.cpp',
     'TestTextFormatter.cpp',
     'TestThreadManager.cpp',
     'TestThreadMetrics.cpp',
     'TestThreadPool.cpp',
     'TestThreadPoolListener.cpp',
-    'TestThreads.cpp',
     'TestThreadUtils.cpp',
     'TestThrottledEventQueue.cpp',
-    'TestTimers.cpp',
     'TestTimeStamp.cpp',
     'TestTokenizer.cpp',
     'TestUTF.cpp',
 ]
 
+if CONFIG['OS_TARGET'] != 'Android':
+    UNIFIED_SOURCES += [
+        'TestAtoms.cpp',
+        'TestBase64.cpp',
+        'TestStrings.cpp',
+        'TestThreads.cpp',
+        'TestTimers.cpp',
+    ]
+
 if CONFIG['MOZ_DEBUG'] and CONFIG['OS_ARCH'] not in ('WINNT') and CONFIG['OS_TARGET'] != 'Android':
     # FIXME bug 523392: TestDeadlockDetector doesn't like Windows
     # Bug 1054249: Doesn't work on Android
     UNIFIED_SOURCES += [
         'TestDeadlockDetector.cpp',
         'TestDeadlockDetectorScalability.cpp',
     ]
 
@@ -79,17 +83,17 @@ if CONFIG['OS_TARGET'] == 'WINNT':
         'TestFilePreferencesWin.cpp',
     ]
 else:
     UNIFIED_SOURCES += [
         'TestFilePreferencesUnix.cpp',
     ]
 
 
-if CONFIG['WRAP_STL_INCLUDES'] and CONFIG['CC_TYPE'] != 'clang-cl':
+if CONFIG['WRAP_STL_INCLUDES'] and CONFIG['CC_TYPE'] != 'clang-cl' and CONFIG['OS_TARGET'] != 'Android':
     UNIFIED_SOURCES += [
         'TestSTLWrappers.cpp',
     ]
 
 # Compile TestAllocReplacement separately so Windows headers don't pollute
 # the global namespace for other files.
 SOURCES += [
     'TestAllocReplacement.cpp',