Bug 1456166 - Downgrade a non-essential assertion to a warning for now because it keeps failing. r=mattwoodrow
authorMats Palmgren <mats@mozilla.com>
Tue, 24 Apr 2018 01:52:51 +0200
changeset 415189 c8375fd1486018c5bfd33f5880cdd7ceab2fdd2a
parent 415188 5bfd3b3d6cc2c45e0682342071d0f635aca86741
child 415190 ef9fa58539c0ab44cc1b85cb74902002417971b9
push id33892
push userebalazs@mozilla.com
push dateTue, 24 Apr 2018 09:42:58 +0000
treeherdermozilla-central@26e53729a109 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1456166
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1456166 - Downgrade a non-essential assertion to a warning for now because it keeps failing. r=mattwoodrow
layout/painting/nsDisplayList.cpp
--- a/layout/painting/nsDisplayList.cpp
+++ b/layout/painting/nsDisplayList.cpp
@@ -2396,18 +2396,19 @@ TreatAsOpaque(nsDisplayItem* aItem, nsDi
 bool
 nsDisplayList::ComputeVisibilityForSublist(nsDisplayListBuilder* aBuilder,
                                            nsRegion* aVisibleRegion,
                                            const nsRect& aListVisibleBounds)
 {
 #ifdef DEBUG
   nsRegion r;
   r.And(*aVisibleRegion, GetBounds(aBuilder));
-  NS_ASSERTION(r.GetBounds().IsEqualInterior(aListVisibleBounds),
-               "bad aListVisibleBounds");
+  // XXX this fails sometimes:
+  NS_WARNING_ASSERTION(r.GetBounds().IsEqualInterior(aListVisibleBounds),
+                       "bad aListVisibleBounds");
 #endif
 
   bool anyVisible = false;
 
   AutoTArray<nsDisplayItem*, 512> elements;
   MoveListTo(this, &elements);
 
   for (int32_t i = elements.Length() - 1; i >= 0; --i) {