Bug 1353208 - Drop a few remaining references to attributeType; r=hiro
authorBrian Birtles <birtles@gmail.com>
Thu, 30 Mar 2017 13:10:06 +0900
changeset 351213 c8006685a3b4ef3d67b50f6dd54388f2f79f2e42
parent 351212 5175ea846fe007a1f13937a562faa1163c540e8f
child 351214 7d136665061434a9286c96b23891e53172d04d0f
push id31603
push usercbook@mozilla.com
push dateWed, 05 Apr 2017 12:30:29 +0000
treeherdermozilla-central@c7e37c13ea9e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershiro
bugs1353208, 1062106
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1353208 - Drop a few remaining references to attributeType; r=hiro These are left over from bug 1062106. MozReview-Commit-ID: 4vfcT4O2tMz
dom/smil/nsSMILCompositor.h
dom/svg/SVGAnimationElement.cpp
--- a/dom/smil/nsSMILCompositor.h
+++ b/dom/smil/nsSMILCompositor.h
@@ -81,17 +81,17 @@ public:
   // sandwich. Also toggles the 'mForceCompositing' flag if it finds that any
   // (used) functions have changed.
   uint32_t GetFirstFuncToAffectSandwich();
 
   // If the passed-in base value differs from our cached base value, this
   // method updates the cached value (and toggles the 'mForceCompositing' flag)
   void UpdateCachedBaseValue(const nsSMILValue& aBaseValue);
 
-  // The hash key (tuple of element/attributeName/attributeType)
+  // The hash key (tuple of element and attributeName)
   KeyType mKey;
 
   // Hash Value: List of animation functions that animate the specified attr
   nsTArray<nsSMILAnimationFunction*> mAnimationFunctions;
 
   // Member data for detecting when we need to force-recompose
   // ---------------------------------------------------------
   // Flag for tracking whether we need to compose. Initialized to false, but
--- a/dom/svg/SVGAnimationElement.cpp
+++ b/dom/svg/SVGAnimationElement.cpp
@@ -243,18 +243,17 @@ SVGAnimationElement::UnbindFromTree(bool
 bool
 SVGAnimationElement::ParseAttribute(int32_t aNamespaceID,
                                     nsIAtom* aAttribute,
                                     const nsAString& aValue,
                                     nsAttrValue& aResult)
 {
   if (aNamespaceID == kNameSpaceID_None) {
     // Deal with target-related attributes here
-    if (aAttribute == nsGkAtoms::attributeName ||
-        aAttribute == nsGkAtoms::attributeType) {
+    if (aAttribute == nsGkAtoms::attributeName) {
       aResult.ParseAtom(aValue);
       AnimationNeedsResample();
       return true;
     }
 
     nsresult rv = NS_ERROR_FAILURE;
 
     // First let the animation function try to parse it...