Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws
authorAaron Klotz <aklotz@mozilla.com>
Thu, 04 Jun 2020 02:05:40 +0000
changeset 533832 c7bb28b233961da4f451aa8f27752ee5bf41d5d0
parent 533831 65c8548cb97d3bb26fab48ebec7625883ec9b04d
child 533833 a900282391e15be8a8f9ed9782a550ff6be11cc7
push id37478
push userabutkovits@mozilla.com
push dateThu, 04 Jun 2020 09:29:07 +0000
treeherdermozilla-central@e87e4800d332 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1642863
milestone79.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws `value` is not a string ID. On desktop this doesn't seem to matter because `value` never passes the `FLUENT_IDENT_REGEX` test. OTOH, on Android it does. Differential Revision: https://phabricator.services.mozilla.com/D77984
toolkit/content/aboutSupport.js
--- a/toolkit/content/aboutSupport.js
+++ b/toolkit/content/aboutSupport.js
@@ -645,17 +645,17 @@ var snapshotFormatters = {
       }
 
       let trs = [];
       for (let [prop, key] of adapterKeys) {
         let value = get(prop);
         if (value === undefined || value === "") {
           continue;
         }
-        trs.push(buildRow(key, value));
+        trs.push(buildRow(key, [new Text(value)]));
       }
 
       if (!trs.length) {
         $("graphics-" + id + "-tbody").style.display = "none";
         return;
       }
 
       let active = "yes";