Bug 1193567 - Check result of ReadID in nsXBLPrototypeBinding::Read(). r=wchen
authorAndrew McCreight <continuation@gmail.com>
Thu, 13 Aug 2015 14:24:59 -0700
changeset 257739 c68650295053ece99cefefee7b7d92ed780e26de
parent 257738 0051268bfb18723c6deb0875a5f656d6bafe8472
child 257740 c32a64e2e4dc0b99771d6964f861a6fb6997f7e3
push id29226
push userryanvm@gmail.com
push dateFri, 14 Aug 2015 13:01:14 +0000
treeherdermozilla-central@1b2402247429 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswchen
bugs1193567
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1193567 - Check result of ReadID in nsXBLPrototypeBinding::Read(). r=wchen
dom/xbl/nsXBLPrototypeBinding.cpp
--- a/dom/xbl/nsXBLPrototypeBinding.cpp
+++ b/dom/xbl/nsXBLPrototypeBinding.cpp
@@ -896,17 +896,18 @@ nsXBLPrototypeBinding::Read(nsIObjectInp
   }
 
   uint32_t interfaceCount;
   rv = aStream->Read32(&interfaceCount);
   NS_ENSURE_SUCCESS(rv, rv);
 
   for (; interfaceCount > 0; interfaceCount--) {
     nsIID iid;
-    aStream->ReadID(&iid);
+    rv = aStream->ReadID(&iid);
+    NS_ENSURE_SUCCESS(rv, rv);
     mInterfaceTable.Put(iid, mBinding);
   }
 
   AutoSafeJSContext cx;
   JS::Rooted<JSObject*> compilationGlobal(cx, xpc::CompilationScope());
   JSAutoCompartment ac(cx, compilationGlobal);
 
   bool isFirstBinding = aFlags & XBLBinding_Serialize_IsFirstBinding;