Bug 1615045 - Remove StartupCache tsan race suppression r=froydnj
authorDoug Thayer <dothayer@mozilla.com>
Fri, 14 Feb 2020 20:29:26 +0000
changeset 514153 c68528f299eb0ba9f3b54fc5b516fb40f882499f
parent 514152 e69118b085175bdec2b8d454a60e5b3406cd6799
child 514154 7504ff45bac426a039ece509f4c34cd133176fda
push id37125
push usershindli@mozilla.com
push dateSat, 15 Feb 2020 09:56:17 +0000
treeherdermozilla-central@02b1aa498dd2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1615045
milestone75.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1615045 - Remove StartupCache tsan race suppression r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D62849
mozglue/build/TsanOptions.cpp
--- a/mozglue/build/TsanOptions.cpp
+++ b/mozglue/build/TsanOptions.cpp
@@ -311,19 +311,16 @@ extern "C" const char* __tsan_default_su
          // Bug 1614706
          "race:CacheFileInputStream::Release\n"
          "race:CacheFileInputStream::CloseWithStatus\n"
 
          // Bug 1615017
          "race:CacheFileMetadata::SetHash\n"
          "race:CacheFileMetadata::OnDataWritten\n"
 
-         // Bug 1615045
-         "race:StartupCache::WriteToDisk\n"
-
          // Bug 1615123
          "race:_dl_deallocate_tls\n"
          "race:__libc_memalign\n"
 
          // Bug 1615121
          "race:CacheEntry::Purge\n"
          "race:CacheEntry::MetaDataReady\n"
 
@@ -364,12 +361,12 @@ extern "C" const char* __tsan_default_su
          "race:simd_support\n"
          "race:jsimd_can_ycc_rgb\n"
          // Likely benign race in ipc/chromium/ where we set
          // `message_loop_` to `NULL` on two threads when stopping
          // a thread at the same time it is already finishing.
          // See also bug 1615228 for discussion.
          "race:base::Thread::Stop\n"
 
-         // End of suppressions.
+      // End of suppressions.
       ;  // Please keep this semicolon.
 }
 #endif  // _MSC_VER