Bug 1501562 - Add crash checking for fennec wpt r=jgraham
☠☠ backed out by 7133f3098dc5 ☠ ☠
authorWes Kocher <wkocher@mozilla.com>
Tue, 23 Apr 2019 21:03:13 +0000
changeset 470562 c666c0a0d04208fa315059b45c0521c880ef7c60
parent 470561 7010f2e2696928f419eecce244fa189725273ada
child 470563 c2a0278aa9ec56ff75ba7a96ee68f3d61b6a1a9f
push id35908
push useraciure@mozilla.com
push dateWed, 24 Apr 2019 04:28:40 +0000
treeherdermozilla-central@c9f0730a57a6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjgraham
bugs1501562
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1501562 - Add crash checking for fennec wpt r=jgraham Differential Revision: https://phabricator.services.mozilla.com/D28161
testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/fennec.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/fennec.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/fennec.py
@@ -106,16 +106,17 @@ class FennecBrowser(FirefoxBrowser):
 
     def __init__(self, logger, prefs_root, test_type, package_name=None,
                  device_serial="emulator-5444", **kwargs):
         FirefoxBrowser.__init__(self, logger, None, prefs_root, test_type, **kwargs)
         self._package_name = package_name
         self.device_serial = device_serial
         self.tests_root = kwargs["tests_root"]
         self.install_fonts = kwargs["install_fonts"]
+        self.stackwalk_binary = kwargs["stackwalk_binary"]
 
     @property
     def package_name(self):
         """
         Name of app to run on emulator.
         """
         if self._package_name is None:
             self._package_name = "org.mozilla.fennec"
@@ -216,8 +217,13 @@ class FennecBrowser(FirefoxBrowser):
                     self.runner.device.device.remove_forwards(
                         "tcp:{}".format(self.marionette_port))
                 except Exception:
                     self.logger.warning("Failed to remove port forwarding")
             # We assume that stopping the runner prompts the
             # browser to shut down. This allows the leak log to be written
             self.runner.stop()
         self.logger.debug("stopped")
+
+    def check_crash(self, process, test):
+        if not os.environ.get("MINIDUMP_STACKWALK", "") and self.stackwalk_binary:
+            os.environ["MINIDUMP_STACKWALK"] = self.stackwalk_binary
+        return self.runner.check_for_crashes()