Bug 1406146 - Fix cross-compartment global issue in typedarary test. r=jandem
authorTed Campbell <tcampbell@mozilla.com>
Wed, 10 Apr 2019 12:50:05 +0000
changeset 468798 c64199fb6020ac6a0fd093d7de961b4fafc21270
parent 468797 32cbcac2b40a061701bb8a9ab9fb5c6d47f30d37
child 468799 e8634d10ef03068a08d6d85c2ce754ff9f0714f2
push id35850
push userdvarga@mozilla.com
push dateWed, 10 Apr 2019 21:52:56 +0000
treeherdermozilla-central@9d3dbe3fef26 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjandem
bugs1406146
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1406146 - Fix cross-compartment global issue in typedarary test. r=jandem This is an artifact of the same-compartment realm changes. The test confuses CCWs and WindowProxies. Differential Revision: https://phabricator.services.mozilla.com/D26847
js/src/tests/non262/extensions/typedarray.js
--- a/js/src/tests/non262/extensions/typedarray.js
+++ b/js/src/tests/non262/extensions/typedarray.js
@@ -540,17 +540,17 @@ function test()
     a = new Uint8Array(100);
     a[99] = 5;
     b = new Uint8Array(a.buffer, 9); // force a offset
     // use a loop to invoke the TM
     for (var i = 0; i < b.length; i++)
         check(() => b[90] == 5)
 
     // Protos and proxies, oh my!
-    var alien = newGlobal();
+    var alien = newGlobal({newCompartment: true});
 
     var alien_view = alien.eval('view = new Uint8Array(7)');
     var alien_buffer = alien.eval('buffer = view.buffer');
 
     // when creating a view of a buffer in a different compartment, the view
     // itself should be created in the other compartment and wrapped for use in
     // this compartment. (There should never be a compartment boundary between
     // an ArrayBufferView and its ArrayBuffer.)