Bug 706974 - devicemanagerADB's pushDir method does not conform to interface specifications. r=jmaher
authorWilliam Lachance <wlach@mozilla.com>
Mon, 05 Dec 2011 07:19:31 -0500
changeset 81450 c63c69abfbfd913b47240112b9fd4029569c4cd1
parent 81449 bbdc154c89b387c8a17b8974a60210c827490215
child 81451 232990286849fe4e26658072b857e451cb368af0
push id21570
push usermbrubeck@mozilla.com
push dateMon, 05 Dec 2011 18:08:26 +0000
treeherdermozilla-central@fafaf614791f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs706974
milestone11.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 706974 - devicemanagerADB's pushDir method does not conform to interface specifications. r=jmaher
build/mobile/devicemanagerADB.py
--- a/build/mobile/devicemanagerADB.py
+++ b/build/mobile/devicemanagerADB.py
@@ -119,20 +119,20 @@ class DeviceManagerADB(DeviceManager):
         for dir in dirs:
           targetDir = remoteDir + "/"
           if (relRoot!="."):
             targetDir = targetDir + relRoot + "/"
           targetDir = targetDir + dir
           if (not self.dirExists(targetDir)):
             self.mkDir(targetDir)
       self.checkCmdAs(["shell", "chmod", "777", remoteDir])
-      return True
+      return remoteDir
     except:
       print "pushing " + localDir + " to " + remoteDir + " failed"
-      return False
+      return None
 
   # external function
   # returns:
   #  success: True
   #  failure: False
   def dirExists(self, dirname):
     return self.isDir(dirname)