Bug 1441740 [wpt PR 9702] - refactor: better naming of things, a=testonly
authorMarcos Cáceres <marcos@marcosc.com>
Mon, 26 Mar 2018 15:20:43 +0000
changeset 411240 c62117966aaaa4260fc94bd24ed3104c5d70f41f
parent 411239 a224ce1fb9e3f6dee50ec49f2d0ccc10dcfb7b1e
child 411241 31a230f81111cc8687f1f79d0ac56e5386b75693
push id33749
push usercsabou@mozilla.com
push dateMon, 02 Apr 2018 10:18:51 +0000
treeherdermozilla-central@c44f60c43432 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1441740
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1441740 [wpt PR 9702] - refactor: better naming of things, a=testonly Automatic update from web-platform-testsnit: better naming of things (#9702) wpt-commits: 44442a796af60e68246890e96864e74da0620f70 wpt-pr: 9702 wpt-commits: 44442a796af60e68246890e96864e74da0620f70 wpt-pr: 9702
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/payment-request/show-method-optional-promise-resolves-manual.https.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -580093,17 +580093,17 @@
    "db68756c6cc3cc2146f608a04988cd938a2dd0de",
    "manual"
   ],
   "payment-request/show-method-optional-promise-rejects-manual.https.html": [
    "62542519059ab38ee0753deff5e7e6e587f8adbf",
    "manual"
   ],
   "payment-request/show-method-optional-promise-resolves-manual.https.html": [
-   "cc65cc042e4eca1c6e70aa2fcc1f48b6ea0e1fa0",
+   "a07f98e117bce1f040c5e62ef3acbd2ef7475338",
    "manual"
   ],
   "payment-request/updateWith-method-pmi-handling-manual.https.html": [
    "b473073ad106e9e0732adb6bfbed5f54d6ec3194",
    "manual"
   ],
   "payment-request/user-abort-algorithm-manual.https.html": [
    "31a6f480d015c6c715df2001b03f487a205a7311",
--- a/testing/web-platform/tests/payment-request/show-method-optional-promise-resolves-manual.https.html
+++ b/testing/web-platform/tests/payment-request/show-method-optional-promise-resolves-manual.https.html
@@ -134,34 +134,34 @@ const passModifiers = failModifiers.map(
         ...passPaymentItem,
         label,
       },
     ],
   };
 });
 
 // PaymentDetailsInit
-const validDetails = Object.freeze({
+const failDetails = Object.freeze({
   displayItems: failPaymentItems,
   id: "this cannot be changed",
   modifiers: failModifiers,
   shippingOptions: failShippingOptions,
   total: failTotal,
 });
 
 const neutralDetails = Object.freeze({
   displayItems: [],
   modifiers: [],
   shippingOptions: [neutralShippingOption],
   total: neutralTotal,
 });
 
 function smokeTest() {
   promise_test(async t => {
-    const request = new PaymentRequest(validMethods, validDetails);
+    const request = new PaymentRequest(validMethods, failDetails);
     await promise_rejects(
       t,
       new TypeError(),
       request.show({
         total: "This throws a TypeError",
       }),
       "expected TypeError"
     );
@@ -173,17 +173,17 @@ function runUpdateDetailsAlgorithm(
   details,
   options = {
     requestShipping: true,
   }
 ) {
   const testAssertion = buttonElement.textContent.trim();
   buttonElement.disabled = true;
   promise_test(async t => {
-    const request = new PaymentRequest(validMethods, validDetails, options);
+    const request = new PaymentRequest(validMethods, failDetails, options);
     const detailsPromise = Promise.resolve(details);
     const acceptPromise = request.show(detailsPromise);
     assert_equals(request.id, "this cant be changed", "id must never change.");
     await promise_rejects(
       t,
       "AbortError",
       acceptPromise,
       "expected AbortError"