b=914030 update AudioNode ownership comment r=roc
authorKarl Tomlinson <karlt+@karlt.net>
Tue, 10 Sep 2013 16:35:47 +1200
changeset 146751 c5e3442b758e2c7959bdecfe2ab7740d6d51fdde
parent 146750 78c1e956df7505f799a21e61d9f1450e745599ff
child 146752 8edc48525bc698e1120c7b7122cd167c6ce90628
push id25270
push useremorley@mozilla.com
push dateThu, 12 Sep 2013 11:04:52 +0000
treeherdermozilla-central@b83f6d80af5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersroc
bugs914030
milestone26.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
b=914030 update AudioNode ownership comment r=roc
content/media/webaudio/AudioNode.h
--- a/content/media/webaudio/AudioNode.h
+++ b/content/media/webaudio/AudioNode.h
@@ -97,21 +97,19 @@ private:
 
 /**
  * The DOM object representing a Web Audio AudioNode.
  *
  * Each AudioNode has a MediaStream representing the actual
  * real-time processing and output of this AudioNode.
  *
  * We track the incoming and outgoing connections to other AudioNodes.
- * All connections are strong and thus rely on cycle collection to break them.
- * However, we also track whether an AudioNode is capable of producing output
- * in the future. If it isn't, then we break its connections to its inputs
- * and outputs, allowing nodes to be immediately disconnected. This
- * disconnection is done internally, invisible to DOM users.
+ * Outgoing connections have strong ownership.  Also, AudioNodes add self
+ * references if they produce sound on their output even when they have silent
+ * or no input.
  */
 class AudioNode : public nsDOMEventTargetHelper,
                   public EnableWebAudioCheck
 {
 protected:
   // You can only use refcounting to delete this object
   virtual ~AudioNode();