Bug 1448305 - Avoid disk cache for icons of private tabs in the TabsLayoutItemView. r=JanH
authorRob Wu <rob@robwu.nl>
Thu, 21 Jun 2018 15:36:27 +0200
changeset 426706 c5b6236aaef8c848ce9e2d3f98ea7a22c1a1c26e
parent 426705 c9034458471c8478c767d7a27ee3cc3b4f76cebe
child 426707 ee63d789769e77377e6246817f900727b23f1289
push id34284
push userbtara@mozilla.com
push dateMon, 16 Jul 2018 21:55:18 +0000
treeherdermozilla-central@da5b3e1dca89 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersJanH
bugs1448305
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1448305 - Avoid disk cache for icons of private tabs in the TabsLayoutItemView. r=JanH
mobile/android/base/java/org/mozilla/gecko/tabs/TabsLayoutItemView.java
--- a/mobile/android/base/java/org/mozilla/gecko/tabs/TabsLayoutItemView.java
+++ b/mobile/android/base/java/org/mozilla/gecko/tabs/TabsLayoutItemView.java
@@ -196,16 +196,17 @@ public class TabsLayoutItemView extends 
 
             final Resources resources = getResources();
             final int iconSize = resources.getDimensionPixelSize(R.dimen.tab_favicon_size);
             final float textSize = resources.getDimensionPixelSize(R.dimen.tab_favicon_text_size);
 
             final Context appContext = getContext().getApplicationContext();
             mOngoingIconLoad = Icons.with(appContext)
                                        .pageUrl(url)
+                                       .setPrivateMode(tab.isPrivate())
                                        .skipNetwork()
                                        .targetSize(iconSize)
                                        .textSize(textSize)
                                        .build()
                                        .execute(mFaviconView.createIconCallback());
 
             mTitle.setContentDescription(tabTitle);
         }