mozilla-central: changeset 416083:c576cede0ed12efe1b15d3617e9cd736b79c4111

author	Timothy Guan-tin Chien <timdream@gmail.com>
	Tue, 17 Apr 2018 18:14:47 +0800
changeset 416083	c576cede0ed12efe1b15d3617e9cd736b79c4111
parent 416082	8e51a02b3d487304ef1e80dc0f87eb51a140e043
child 416084	09f7885a83ce43f44209d938e982316067446e5e
push id	33916
push user	apavel@mozilla.com
push date	Sat, 28 Apr 2018 17:29:16 +0000
treeherder	mozilla-central@807e94988d9a [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	Ehsan
bugs	1451576
milestone	61.0a1
first release with	nightly linux32 08f68e2c892c / 61.0a1 / 20180428220114 / files nightly linux64 08f68e2c892c / 61.0a1 / 20180428220114 / files nightly mac 08f68e2c892c / 61.0a1 / 20180428220114 / files nightly win32 08f68e2c892c / 61.0a1 / 20180428220114 / files nightly win64 08f68e2c892c / 61.0a1 / 20180428220114 / files
last release without	nightly linux32 d2d518b1f873 / 61.0a1 / 20180427102245 / files nightly linux64 d2d518b1f873 / 61.0a1 / 20180427102245 / files nightly mac d2d518b1f873 / 61.0a1 / 20180427102245 / files nightly win32 d2d518b1f873 / 61.0a1 / 20180427102245 / files nightly win64 d2d518b1f873 / 61.0a1 / 20180427102245 / files

Bug 1451576 - Add dir=auto to subtitle menu items in video control r=Ehsan The labels of the subtitle track selections come from the web content, from <track label="...">. Given that it will likely be the name of the language in its native writing system, each of the item should have its own directionality, instead of inheriting direction: ltr set on the entire <xul:videocontrol> parent element. I do however wonders if the web content should have the opportunity to affect the directionality of these labels? We would need clarification from the spec to tell if this fix is already adequate. MozReview-Commit-ID: G4I2Wf9gFCu

toolkit/content/widgets/videocontrols.xml

file | annotate | diff | comparison | revisions

--- a/toolkit/content/widgets/videocontrols.xml
+++ b/toolkit/content/widgets/videocontrols.xml
@@ -1651,16 +1651,17 @@
         tt.index = this.textTracksCount++;
 
         const label = tt.label || "";
         const ttText = document.createTextNode(label);
         const ttBtn = document.createElement("button");
 
         ttBtn.classList.add("textTrackItem");
         ttBtn.setAttribute("index", tt.index);
+        ttBtn.setAttribute("dir", "auto");
         ttBtn.appendChild(ttText);
 
         this.textTrackList.appendChild(ttBtn);
 
         if (tt.mode === "showing" && tt.index) {
           this.changeTextTrack(tt.index);
         }
       },