Bug 895939 - Click-to-activate plugin notification is ugly, r=jaws
authorBenjamin Smedberg <benjamin@smedbergs.us>
Fri, 26 Jul 2013 20:52:21 -0400
changeset 140234 c456780d7d1f7c4f6e4cf927b44a98305d8006b5
parent 140233 48d3d69fd9b103b5a6f12680492c32e9b9858bed
child 140235 7a41bb1a3c9d1c17fd68bb01ed3bad0dc09319fc
push id25020
push userryanvm@gmail.com
push dateSat, 27 Jul 2013 22:13:14 +0000
treeherdermozilla-central@75e2498668df [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs895939
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 895939 - Click-to-activate plugin notification is ugly, r=jaws
browser/themes/osx/browser.css
browser/themes/shared/plugin-doorhanger.inc.css
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -3651,16 +3651,26 @@ toolbarbutton.chevron > .toolbarbutton-m
   font-size: 120%;
 }
 
 %include ../shared/devtools/responsivedesign.inc.css
 %include ../shared/devtools/highlighter.inc.css
 %include ../shared/devtools/commandline.inc.css
 %include ../shared/plugin-doorhanger.inc.css
 
+/* On mac, the popup notification contents are indented by default and so
+  the default closebutton margins from notification.css require adjustment */
+
+.click-to-play-plugins-notification-description-box > .popup-notification-closebutton {
+  -moz-margin-end: -6px;
+  margin-top: -7px;
+}
+
+
+
 .gclitoolbar-input-node > .textbox-input-box > html|*.textbox-input::-moz-selection {
   color: hsl(210,11%,16%);
 }
 
 /* Developer Toolbar */
 
 #developer-toolbar-closebutton {
   margin-left: 8px;
--- a/browser/themes/shared/plugin-doorhanger.inc.css
+++ b/browser/themes/shared/plugin-doorhanger.inc.css
@@ -2,55 +2,52 @@
   padding: 0px;
 }
 
 .click-to-play-plugins-notification-content {
   width: 28em;
 }
 
 .click-to-play-plugins-notification-center-box {
-  background-color: rgba(255,255,255,0.3);
+  border: 1px solid ThreeDShadow;
+  margin: 10px;
 }
 
-.plugin-popupnotification-centeritem {
-  border-top: 1px solid ThreeDShadow;
+.plugin-popupnotification-centeritem:nth-child(odd) {
+  background-color: rgba(0,0,0,0.1);
 }
 
 .center-item-label {
+  -moz-margin-start: 6px;
   margin-bottom: 0;
   text-overflow: ellipsis;
 }
 
 .center-item-warning-icon {
   background-image: url("chrome://mozapps/skin/extensions/alerticon-info-negative.png");
   background-repeat: no-repeat;
   width: 16px;
   height: 15px;
   -moz-margin-start: 6px;
 }
 
 .click-to-play-plugins-notification-button-container {
-  border-top: 1px solid ThreeDShadow;
+  background: linear-gradient(rgba(0,0,0,0.04) 60%, transparent);
+  padding: 10px;
+  margin-top: 5px;
 }
 
 .click-to-play-popup-button {
   width: 50%;
 }
 
 .click-to-play-plugins-notification-description-box {
-  margin-left: 10px;
-  margin-right: 10px;
-  margin-top: 2px;
-  padding-bottom: 2px;
+  padding: 10px;
 }
 
 .click-to-play-plugins-outer-description {
   margin-top: 8px;
 }
 
-.click-to-play-plugins-notification-description-box > .popup-notification-closebutton {
-  margin: 0;
-}
-
 .click-to-play-plugins-notification-link,
 .center-item-link {
   margin: 0;
 }