Bug 1476594 - Fix default homepage selection in about:preferences r=ursula
authorahillier <ahillier@mozilla.com>
Fri, 27 Jul 2018 13:33:57 -0700
changeset 428802 c3309f635b9028f3475f1498b60780cb55a9d1f2
parent 428801 ff16973184c057c56849ec0bba80742205ea05df
child 428803 e094751856778076932604c904c1d269fd3e6fac
push id34345
push userrgurzau@mozilla.com
push dateSat, 28 Jul 2018 09:44:50 +0000
treeherdermozilla-central@8a1379826329 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersursula
bugs1476594
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476594 - Fix default homepage selection in about:preferences r=ursula MozReview-Commit-ID: HlqsWitmIOv
browser/components/preferences/in-content/home.js
--- a/browser/components/preferences/in-content/home.js
+++ b/browser/components/preferences/in-content/home.js
@@ -257,17 +257,17 @@ var gHomePane = {
     const homePref = Preferences.get("browser.startup.homepage");
 
     switch (value) {
       case this.HOME_MODE_FIREFOX_HOME:
         if (startupPref.value === gMainPane.STARTUP_PREF_BLANK) {
           startupPref.value = gMainPane.STARTUP_PREF_HOMEPAGE;
         }
         if (homePref.value !== homePref.defaultValue) {
-          homePref.value = homePref.defaultValue;
+          Services.prefs.clearUserPref(homePref.id);
         } else {
           this._renderCustomSettings({shouldShow: false});
         }
         break;
       case this.HOME_MODE_BLANK:
         if (homePref.value !== "about:blank") {
           homePref.value = "about:blank";
         } else {