Backed out changeset 1c40cef0e222 (bug 1469318) for mochitest failures on test_ext_all_apis.html CLOSED TREE
authorBrindusan Cristian <cbrindusan@mozilla.com>
Mon, 18 Jun 2018 22:18:28 +0300
changeset 422852 c2ced94f52aade1532494cfdd31d6fdacd3f1edf
parent 422851 0708df4d3b7a8c38dd32f52d3199e5a27a0758f2
child 422853 854d98803f6925fc8cb96f4ded4d7ad7de3e5922
child 422869 64e9597a6e970c9cedb1ad6663ffa94fd9d5b470
push id34155
push usershindli@mozilla.com
push dateMon, 18 Jun 2018 21:39:31 +0000
treeherdermozilla-central@854d98803f69 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1469318
milestone62.0a1
backs out1c40cef0e22283838e3ec74b52c19cd2e9da2a70
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 1c40cef0e222 (bug 1469318) for mochitest failures on test_ext_all_apis.html CLOSED TREE
toolkit/components/extensions/schemas/theme.json
toolkit/components/extensions/test/browser/browser_ext_themes_getCurrent_differentExt.js
toolkit/components/extensions/test/browser/browser_ext_themes_static_onUpdated.js
--- a/toolkit/components/extensions/schemas/theme.json
+++ b/toolkit/components/extensions/schemas/theme.json
@@ -580,16 +580,17 @@
           }
         }
       }
     ]
   },
   {
     "namespace": "theme",
     "description": "The theme API allows customizing of visual elements of the browser.",
+    "permissions": ["theme"],
     "types": [
       {
         "id": "ThemeUpdateInfo",
         "type": "object",
         "description": "Info provided in the onUpdated listener.",
         "properties": {
           "theme": {
             "type": "object",
@@ -632,17 +633,16 @@
           }
         ]
       },
       {
         "name": "update",
         "type": "function",
         "async": true,
         "description": "Make complete updates to the theme. Resolves when the update has completed.",
-        "permissions": ["theme"],
         "parameters": [
           {
             "type": "integer",
             "name": "windowId",
             "optional": true,
             "description": "The id of the window to update. No id updates all windows."
           },
           {
@@ -652,17 +652,16 @@
           }
         ]
       },
       {
         "name": "reset",
         "type": "function",
         "async": true,
         "description": "Removes the updates made to the theme.",
-        "permissions": ["theme"],
         "parameters": [
           {
             "type": "integer",
             "name": "windowId",
             "optional": true,
             "description": "The id of the window to reset. No id resets all windows."
           }
         ]
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_getCurrent_differentExt.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_getCurrent_differentExt.js
@@ -24,16 +24,19 @@ add_task(async function test_getcurrent(
   const extension = ExtensionTestUtils.loadExtension({
     background() {
       browser.theme.onUpdated.addListener(() => {
         browser.theme.getCurrent().then(theme => {
           browser.test.sendMessage("theme-updated", theme);
         });
       });
     },
+    manifest: {
+      permissions: ["theme"],
+    },
   });
 
   await extension.startup();
 
   info("Testing getCurrent after static theme startup");
   let updatedPromise = extension.awaitMessage("theme-updated");
   await theme.startup();
   let receivedTheme = await updatedPromise;
--- a/toolkit/components/extensions/test/browser/browser_ext_themes_static_onUpdated.js
+++ b/toolkit/components/extensions/test/browser/browser_ext_themes_static_onUpdated.js
@@ -22,16 +22,19 @@ add_task(async function test_on_updated(
   });
 
   const extension = ExtensionTestUtils.loadExtension({
     background() {
       browser.theme.onUpdated.addListener(updateInfo => {
         browser.test.sendMessage("theme-updated", updateInfo);
       });
     },
+    manifest: {
+      permissions: ["theme"],
+    },
   });
 
   await extension.startup();
 
   info("Testing update event on static theme startup");
   let updatedPromise = extension.awaitMessage("theme-updated");
   await theme.startup();
   const {theme: receivedTheme, windowId} = await updatedPromise;