Bug 1422540 - move --enable-gczeal to moz.configure; r=nalexander
authorNathan Froyd <froydnj@mozilla.com>
Sun, 03 Dec 2017 13:40:03 -0500
changeset 394619 c2b53ecee2dd8cdd7e206b94bd957e0b42f1fa5a
parent 394618 362425ee97adff2662b5dbf2d237be5d89b9e303
child 394620 33ab7736c435fdf4503b2267326832fc1d598808
push id33016
push userdluca@mozilla.com
push dateMon, 04 Dec 2017 10:46:42 +0000
treeherdermozilla-central@785572419acc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1422540
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1422540 - move --enable-gczeal to moz.configure; r=nalexander
build/moz.configure/old.configure
js/moz.configure
js/src/old-configure.in
--- a/build/moz.configure/old.configure
+++ b/build/moz.configure/old.configure
@@ -182,17 +182,16 @@ def old_configure_options(*options):
     '--enable-directshow',
     '--enable-dtrace',
     '--enable-dump-painting',
     '--enable-extensions',
     '--enable-faststripe',
     '--enable-feeds',
     '--enable-gamepad',
     '--enable-gconf',
-    '--enable-gczeal',
     '--enable-hardware-aec-ns',
     '--enable-icf',
     '--enable-install-strip',
     '--enable-ios-target',
     '--enable-libjpeg-turbo',
     '--enable-libproxy',
     '--enable-llvm-hacks',
     '--enable-logrefcnt',
--- a/js/moz.configure
+++ b/js/moz.configure
@@ -269,16 +269,24 @@ js_option('--enable-gc-trace', env='JS_G
 @depends('--enable-gc-trace')
 def gc_trace(value):
     if value:
         return True
 
 set_define('JS_GC_TRACE', gc_trace)
 
 
+js_option('--enable-gczeal',
+          default=depends(when=moz_debug)(lambda: True),
+          help='Enable zealous GCing')
+
+set_define('JS_GC_ZEAL',
+           depends_if('--enable-gczeal')(lambda _: True))
+
+
 # Trace logging.
 # =======================================================
 js_option('--enable-trace-logging',
           default=depends(when=moz_debug)(lambda: True),
           help='Enable trace logging')
 
 set_config('ENABLE_TRACE_LOGGING',
            depends_if('--enable-trace-logging')(lambda x: True))
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -1549,27 +1549,16 @@ fi
 dnl ========================================================
 dnl Debug (see Bug 939505)
 dnl ========================================================
 if test -n "$MOZ_DEBUG"; then
     AC_DEFINE(JS_DEBUG)
 fi
 
 dnl ========================================================
-dnl Zealous JavaScript GC
-dnl ========================================================
-MOZ_ARG_ENABLE_BOOL(gczeal,
-[  --enable-gczeal         Enable zealous GCing],
-    JS_GC_ZEAL=1,
-    JS_GC_ZEAL= )
-if test -n "$JS_GC_ZEAL" -o -n "$MOZ_DEBUG"; then
-    AC_DEFINE(JS_GC_ZEAL)
-fi
-
-dnl ========================================================
 dnl Enable breakpoint for artificial OOMs
 dnl ========================================================
 MOZ_ARG_ENABLE_BOOL(oom-breakpoint,
 [  --enable-oom-breakpoint
                           Enable a breakpoint function for artificial OOMs],
     JS_OOM_BREAKPOINT=1,
     JS_OOM_BREAKPOINT= )
 if test -n "$JS_OOM_BREAKPOINT"; then