Bug 473268 - We should use forget instead of swap in mozStorageService.cpp; r=sdwilsh
authorNilay Vaish <nilayvaish@yahoo.com>
Tue, 03 Feb 2009 15:42:28 +0100
changeset 24556 c23d77b0d600caf566adb12736ef7adfc3fe106e
parent 24555 6d123d6a104ac0a5eaffdc98e91c0148ee7d9f0f
child 24557 332c6aaee89c53421e6ec62e7e36a1d110844cab
push id5113
push usersgautherie.bz@free.fr
push dateTue, 03 Feb 2009 14:44:19 +0000
treeherdermozilla-central@c23d77b0d600 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssdwilsh
bugs473268
milestone1.9.2a1pre
Bug 473268 - We should use forget instead of swap in mozStorageService.cpp; r=sdwilsh
storage/src/mozStorageService.cpp
--- a/storage/src/mozStorageService.cpp
+++ b/storage/src/mozStorageService.cpp
@@ -297,17 +297,17 @@ mozStorageService::BackupDatabaseFile(ns
 
     nsAutoString fileName;
     rv = backupDB->GetLeafName(fileName);
     NS_ENSURE_SUCCESS(rv, rv);
 
     rv = backupDB->Remove(PR_FALSE);
     NS_ENSURE_SUCCESS(rv, rv);
 
-    backupDB.swap(*backup);
+    backupDB.forget(backup);
 
     return aDBFile->CopyTo(parentDir, fileName);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 //// nsIObserver
 
 NS_IMETHODIMP