Bug 1476165 - Part 1c: Fix Android Lint - TextFields: Missing inputType. r=nalexander
authorTudor-Gabriel Vîjială <tvijiala@mozilla.com>
Mon, 23 Jul 2018 11:40:16 +0100
changeset 428360 c1bbc1019bd3
parent 428359 dd0c6edcb031
child 428361 de5477d9e048
push id34333
push usercbrindusan@mozilla.com
push dateWed, 25 Jul 2018 21:36:06 +0000
treeherdermozilla-central@daacc8061a8f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1476165
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476165 - Part 1c: Fix Android Lint - TextFields: Missing inputType. r=nalexander MozReview-Commit-ID: DTTWNNeg4Uv
mobile/android/app/src/main/res/layout/bookmark_add_folder.xml
mobile/android/app/src/main/res/layout/bookmark_edit.xml
mobile/android/app/src/main/res/layout/bookmark_edit_with_full_page.xml
--- a/mobile/android/app/src/main/res/layout/bookmark_add_folder.xml
+++ b/mobile/android/app/src/main/res/layout/bookmark_add_folder.xml
@@ -36,16 +36,17 @@
         <android.support.design.widget.TextInputLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:layout_marginBottom="8dp"
             android:layout_marginTop="16dp">
 
             <EditText
                 android:id="@+id/edit_folder_name"
+                android:inputType="text"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:ellipsize="end"
                 android:hint="@string/bookmark_edit_name"
                 android:maxLines="1"
                 android:singleLine="true"
                 android:textSize="18sp"
                 android:textColor="@color/text_and_tabs_tray_grey" />
--- a/mobile/android/app/src/main/res/layout/bookmark_edit.xml
+++ b/mobile/android/app/src/main/res/layout/bookmark_edit.xml
@@ -11,16 +11,17 @@
               android:layout_height="match_parent">
 
     <android.support.design.widget.TextInputLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content">
 
         <EditText
                 android:id="@+id/edit_bookmark_name"
+                android:inputType="text"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:singleLine="true"
                 android:hint="@string/bookmark_edit_name"
                 />
     </android.support.design.widget.TextInputLayout>
 
     <android.support.design.widget.TextInputLayout
@@ -37,15 +38,16 @@
     </android.support.design.widget.TextInputLayout>
 
     <android.support.design.widget.TextInputLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content">
 
         <EditText
                 android:id="@+id/edit_bookmark_keyword"
+                android:inputType="text"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:singleLine="true"
                 android:hint="@string/bookmark_edit_keyword"/>
     </android.support.design.widget.TextInputLayout>
 
 </LinearLayout>
--- a/mobile/android/app/src/main/res/layout/bookmark_edit_with_full_page.xml
+++ b/mobile/android/app/src/main/res/layout/bookmark_edit_with_full_page.xml
@@ -40,16 +40,17 @@
                 android:layout_height="wrap_content"
                 android:layout_marginBottom="8dp"
                 android:layout_marginTop="16dp">
 
                 <EditText
                     android:id="@+id/edit_bookmark_name"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
+                    android:inputType="text"
                     android:ellipsize="end"
                     android:gravity="start"
                     android:hint="@string/bookmark_edit_name"
                     android:maxLines="1"
                     android:singleLine="true"
                     android:textColor="@color/text_and_tabs_tray_grey"
                     android:textSize="18sp"
                     android:focusable="true"