Bug 751509 - Don't assert that about:memory percentages are less than 100%. r=njn
☠☠ backed out by 05d1ae4caf36 ☠ ☠
authorJustin Lebar <justin.lebar@gmail.com>
Fri, 04 May 2012 12:50:12 -0400
changeset 93192 c1243d1fb401b989f90fb462b4eac57b6601630b
parent 93191 e0a8b01b259abbbea59f4e05c380e253ac2347d3
child 93193 5697962128e45a49771df1ee72e02b9ab9a86963
push id22616
push userMs2ger@gmail.com
push dateSat, 05 May 2012 08:59:35 +0000
treeherdermozilla-central@ea4c62f4c063 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs751509
milestone15.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 751509 - Don't assert that about:memory percentages are less than 100%. r=njn
toolkit/components/aboutmemory/content/aboutMemory.js
--- a/toolkit/components/aboutmemory/content/aboutMemory.js
+++ b/toolkit/components/aboutmemory/content/aboutMemory.js
@@ -1410,17 +1410,17 @@ OtherReport.prototype = {
   },
 
   isInvalid: function() {
     let n = this._amount;
     switch (this._units) {
       case UNITS_BYTES:
       case UNITS_COUNT:
       case UNITS_COUNT_CUMULATIVE: return n < 0;
-      case UNITS_PERCENTAGE:       return !(0 <= n && n <= 10000);
+      case UNITS_PERCENTAGE:       return n < 0; /* percentages may be greater than 100% */
       default:
         assert(false, "bad units in OtherReport.isInvalid");
     }
   }
 };
 
 OtherReport.compare = function(a, b) {
   return a._unsafePath < b._unsafePath ? -1 :