Bug 1481466 - Avoid a style change to work around a XUL reflow bug. r=paolo
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 22 Aug 2018 09:40:26 +0100
changeset 432797 c0f5b64fe563a74d5d23f5aa5199a437cb8fd745
parent 432796 fd86a6388333a146b2ca7dcea00f3e3343aae139
child 432798 4b7383b27f89dcb1732b27f6d68f1684f36ff377
push id34488
push usernerli@mozilla.com
push dateWed, 22 Aug 2018 16:28:54 +0000
treeherdermozilla-central@d6e4d3e69d4c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspaolo
bugs1481466
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1481466 - Avoid a style change to work around a XUL reflow bug. r=paolo When adjustArrowPosition sets the "side" attribute, it causes a reflow that triggers a XUL layout bug. By setting the attribute in advance, we avoid the reflow.
browser/base/content/browser.xul
--- a/browser/base/content/browser.xul
+++ b/browser/base/content/browser.xul
@@ -1116,16 +1116,17 @@ xmlns="http://www.w3.org/1999/xhtml"
                      ondragleave="PlacesMenuDNDHandler.onDragLeave(event);"
                      ondrop="PlacesMenuDNDHandler.onDrop(event);"
                      oncommand="BookmarkingUI.onCommand(event);">
         <menupopup id="BMB_bookmarksPopup"
                    class="cui-widget-panel cui-widget-panelview cui-widget-panelWithFooter PanelUI-subView"
                    placespopup="true"
                    context="placesContext"
                    openInTabs="children"
+                   side="top"
                    onmouseup="BookmarksEventHandler.onMouseUp(event);"
                    oncommand="BookmarksEventHandler.onCommand(event);"
                    onclick="BookmarksEventHandler.onClick(event, this.parentNode._placesView);"
                    onpopupshowing="BookmarkingUI.onPopupShowing(event);
                                    BookmarkingUI.attachPlacesView(event, this);"
                    tooltip="bhTooltip" popupsinherittooltip="true">
           <menuitem id="BMB_viewBookmarksSidebar"
                     class="menuitem-iconic subviewbutton"