bug 1540655: remote: ignore non-vendored Node.js assets; r=remote-protocol-reviewers,jdescottes
☠☠ backed out by 79127c2c7123 ☠ ☠
authorAndreas Tolfsen <ato@sny.no>
Wed, 14 Aug 2019 14:58:02 +0000
changeset 487922 c0a80d37576d533c77544dc434b2618651351c9e
parent 487921 939ce2afcf0b550a4d6e5ae7e3b3f68c41bcd73c
child 487923 8c67b494e207a626fd6638ad9de3b01ad61c66e2
push id36433
push userbtara@mozilla.com
push dateWed, 14 Aug 2019 21:57:52 +0000
treeherdermozilla-central@7d9a2196d313 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersremote-protocol-reviewers, jdescottes
bugs1540655
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1540655: remote: ignore non-vendored Node.js assets; r=remote-protocol-reviewers,jdescottes We vendor the Puppeteer library, but not its dependencies. When "npm install" is called in remote/test/puppeteer/, it puts its dependencies under remote/test/puppeteer/node_modules/ and generates a remote/test/puppeteer/package-lock.json file. We do not want these to be checked in. DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D37010
.hgignore
remote/.gitignore
--- a/.hgignore
+++ b/.hgignore
@@ -94,16 +94,20 @@ compile_commands\.json
 
 # Ignore chrome.manifest files from the devtools loader
 ^devtools/client/chrome.manifest$
 ^devtools/shared/chrome.manifest$
 
 # Ignore node_modules directories in devtools
 ^devtools/.*/node_modules/
 
+# Ignore node_module directories and npm artifacts
+^remote/test/puppeteer/package-lock.json
+^remote/test/puppeteer/node_modules/
+
 # git checkout of libstagefright
 ^media/libstagefright/android$
 
 # Tag files generated by GNU Global
 (^|/)GTAGS$
 (^|/)GRTAGS$
 (^|/)GSYMS$
 (^|/)GPATH$
new file mode 100644
--- /dev/null
+++ b/remote/.gitignore
@@ -0,0 +1,2 @@
+test/puppeteer/package-lock.json
+test/puppeteer/node_modules/