Bug 1572987 [wpt PR 18375] - [css-align] [css-multicol] Move column-gap parsing, a=testonly
authorEric Willigers <ewilligers@users.noreply.github.com>
Wed, 14 Aug 2019 10:55:19 +0000
changeset 488098 c09e52feec63f2617c9483221e3bc4ad8a46b727
parent 488097 3a2c535167837a06504e8c265bbb4706c1a38b88
child 488099 c9694304fca4accbcb7c49a386e81dab34b961c2
push id36435
push usercbrindusan@mozilla.com
push dateThu, 15 Aug 2019 09:46:49 +0000
treeherdermozilla-central@0db07ff50ab5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1572987, 18375
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1572987 [wpt PR 18375] - [css-align] [css-multicol] Move column-gap parsing, a=testonly Automatic update from web-platform-tests [css-align] [css-multicol] Move column-gap parsing (#18375) column-gap is now defined only in CSS Box Alignment, so we move the column-gap parsing tests out of CSS Multi-column Layout. https://drafts.csswg.org/css-align-3/#column-row-gap -- wpt-commits: 2f08203a98291809cf67839232d45e68752dcb25 wpt-pr: 18375
testing/web-platform/tests/css/css-align/parsing/column-gap-computed.html
testing/web-platform/tests/css/css-align/parsing/column-gap-invalid.html
testing/web-platform/tests/css/css-align/parsing/column-gap-valid.html
testing/web-platform/tests/css/css-multicol/inheritance.html
testing/web-platform/tests/css/css-multicol/parsing/column-gap-computed.html
testing/web-platform/tests/css/css-multicol/parsing/column-gap-invalid.html
testing/web-platform/tests/css/css-multicol/parsing/column-gap-valid.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-align/parsing/column-gap-computed.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<title>CSS Box Alignment Level 3: getComputedStyle().columnGap</title>
+<link rel="help" href="https://drafts.csswg.org/css-align-3/#propdef-column-gap">
+<meta name="assert" content="column-gap computed value is as specified.">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/css/support/computed-testcommon.js"></script>
+</head>
+<body>
+<div id="target"></div>
+<style>
+  #target {
+    font-size: 40px;
+  }
+</style>
+<script>
+test_computed_value("column-gap", "normal");
+
+test_computed_value("column-gap", "calc(10px + 0.5em)", "30px");
+test_computed_value("column-gap", "calc(10px - 0.5em)", "0px");
+test_computed_value("column-gap", "40%");
+test_computed_value("column-gap", "calc(50% + 60px)");
+</script>
+</body>
+</html>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-align/parsing/column-gap-invalid.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<title>CSS Box Alignment Level 3: parsing column-gap with invalid values</title>
+<link rel="help" href="https://drafts.csswg.org/css-align-3/#propdef-column-gap">
+<meta name="assert" content="column-gap supports only the grammar '<length-percentage> | normal'.">
+<meta name="assert" content="column-gap rejects negative <length-percentage>.">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/css/support/parsing-testcommon.js"></script>
+</head>
+<body>
+<script>
+test_invalid_value("column-gap", "auto");
+
+test_invalid_value("column-gap", "10");
+test_invalid_value("column-gap", "10px 20px");
+test_invalid_value("column-gap", "-1px");
+test_invalid_value("column-gap", "-10%");
+</script>
+</body>
+</html>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-align/parsing/column-gap-valid.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<title>CSS Box Alignment Level 3: parsing column-gap with valid values</title>
+<link rel="help" href="https://drafts.csswg.org/css-align-3/#propdef-column-gap">
+<meta name="assert" content="column-gap supports the full grammar '<length-percentage> | normal'.">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/css/support/parsing-testcommon.js"></script>
+</head>
+<body>
+<script>
+test_valid_value("column-gap", "normal");
+
+test_valid_value("column-gap", "0", "0px");
+test_valid_value("column-gap", "1px");
+test_valid_value("column-gap", "calc(2em + 3ex)");
+test_valid_value("column-gap", "4%");
+test_valid_value("column-gap", "5vmin");
+</script>
+</body>
+</html>
--- a/testing/web-platform/tests/css/css-multicol/inheritance.html
+++ b/testing/web-platform/tests/css/css-multicol/inheritance.html
@@ -29,17 +29,16 @@
   }
 </style>
 <script>
 const mediumWidth = getComputedStyle(reference).borderTopWidth; // e.g. 3px
 reference.style.display = 'none';
 
 assert_not_inherited('column-count', 'auto', '2');
 assert_not_inherited('column-fill', 'balance', 'auto');
-assert_not_inherited('column-gap', 'normal', '10px');
 assert_not_inherited('column-rule-color', 'rgba(42, 53, 64, 0.75)', 'rgba(2, 3, 5, 0.5)');
 assert_not_inherited('column-rule-style', 'none', 'dashed');
 assert_not_inherited('column-rule-width', mediumWidth, '10px');
 assert_not_inherited('column-span', 'none', 'all');
 assert_not_inherited('column-width', 'auto', '10px');
 </script>
 </body>
 </html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-multicol/parsing/column-gap-computed.html
+++ /dev/null
@@ -1,28 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="utf-8">
-<title>CSS Multi-column Layout: getComputedStyle().columnGap</title>
-<link rel="help" href="https://drafts.csswg.org/css-multicol/#propdef-column-gap">
-<meta name="assert" content="column-gap computed value is as specified.">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script src="/css/support/computed-testcommon.js"></script>
-</head>
-<body>
-<div id="target"></div>
-<style>
-  #target {
-    font-size: 40px;
-  }
-</style>
-<script>
-test_computed_value("column-gap", "normal");
-
-test_computed_value("column-gap", "calc(10px + 0.5em)", "30px");
-test_computed_value("column-gap", "calc(10px - 0.5em)", "0px");
-test_computed_value("column-gap", "40%");
-test_computed_value("column-gap", "calc(50% + 60px)");
-</script>
-</body>
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-multicol/parsing/column-gap-invalid.html
+++ /dev/null
@@ -1,23 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="utf-8">
-<title>CSS Multi-column Layout: parsing column-gap with invalid values</title>
-<link rel="help" href="https://drafts.csswg.org/css-multicol/#propdef-column-gap">
-<meta name="assert" content="column-gap supports only the grammar '<length-percentage> | normal'.">
-<meta name="assert" content="column-gap rejects negative <length-percentage>.">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script src="/css/support/parsing-testcommon.js"></script>
-</head>
-<body>
-<script>
-test_invalid_value("column-gap", "auto");
-
-test_invalid_value("column-gap", "10");
-test_invalid_value("column-gap", "10px 20px");
-test_invalid_value("column-gap", "-1px");
-test_invalid_value("column-gap", "-10%");
-</script>
-</body>
-</html>
deleted file mode 100644
--- a/testing/web-platform/tests/css/css-multicol/parsing/column-gap-valid.html
+++ /dev/null
@@ -1,23 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<meta charset="utf-8">
-<title>CSS Multi-column Layout: parsing column-gap with valid values</title>
-<link rel="help" href="https://drafts.csswg.org/css-multicol/#propdef-column-gap">
-<meta name="assert" content="column-gap supports the full grammar '<length-percentage> | normal'.">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<script src="/css/support/parsing-testcommon.js"></script>
-</head>
-<body>
-<script>
-test_valid_value("column-gap", "normal");
-
-test_valid_value("column-gap", "0", "0px");
-test_valid_value("column-gap", "1px");
-test_valid_value("column-gap", "calc(2em + 3ex)");
-test_valid_value("column-gap", "4%");
-test_valid_value("column-gap", "5vmin");
-</script>
-</body>
-</html>