Bug 1536675 - Inline MOZ_Crash even in debug builds r=froydnj
authorDavid Major <dmajor@mozilla.com>
Fri, 05 Apr 2019 19:25:55 +0000
changeset 468227 c077a1a6162930c4385039a24ad73692363cbec0
parent 468226 365223fc9f865212c0f42948763ec48d4dca03ff
child 468228 cbf847b4007c85e2739a91434877d9914c1694a7
push id35824
push userapavel@mozilla.com
push dateSat, 06 Apr 2019 10:57:50 +0000
treeherdermozilla-central@a765634b9ec2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1536675
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1536675 - Inline MOZ_Crash even in debug builds r=froydnj We want MOZ_Crash frames to stay out of Taskcluster logs even on debug builds. Perhaps you could say, _especially_ on debug builds. Differential Revision: https://phabricator.services.mozilla.com/D26352
mfbt/Assertions.h
--- a/mfbt/Assertions.h
+++ b/mfbt/Assertions.h
@@ -299,17 +299,17 @@ MOZ_NoReturn(int aLine) {
  * strings from a potentially compromised process is not without risk. If the
  * string being passed is the result of a printf-style function, consider using
  * MOZ_CRASH_UNSAFE_PRINTF instead.
  *
  * @note This macro causes data collection because crash strings are annotated
  * to crash-stats and are publicly visible. Firefox data stewards must do data
  * review on usages of this macro.
  */
-static MOZ_ALWAYS_INLINE MOZ_COLD MOZ_NORETURN void MOZ_Crash(
+static MOZ_ALWAYS_INLINE_EVEN_DEBUG MOZ_COLD MOZ_NORETURN void MOZ_Crash(
     const char* aFilename, int aLine, const char* aReason) {
 #ifdef DEBUG
   MOZ_ReportCrash(aReason, aFilename, aLine);
 #endif
   MOZ_CRASH_ANNOTATE(aReason);
   MOZ_REALLY_CRASH(aLine);
 }
 #define MOZ_CRASH_UNSAFE(reason) MOZ_Crash(__FILE__, __LINE__, reason)