Bug 1355752 - Remove B2G wording in AccessibleCaret. r=TYLin
authorAstley Chen <aschen@mozilla.com>
Thu, 20 Apr 2017 13:16:42 +0800
changeset 354012 c018f36dcdad48f6832382b72e82b16f3671f881
parent 354011 31db93715b92dbd11038cf8ced3331a866ea627a
child 354013 e42cf4911d08a0aabb8d948bd84212c73eec2c9b
push id31685
push userkwierso@gmail.com
push dateThu, 20 Apr 2017 21:45:29 +0000
treeherdermozilla-central@5e3dc7e1288a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersTYLin
bugs1355752
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1355752 - Remove B2G wording in AccessibleCaret. r=TYLin MozReview-Commit-ID: JOv2caZc8J0
layout/base/AccessibleCaret.cpp
layout/base/gtest/TestAccessibleCaretManager.cpp
--- a/layout/base/AccessibleCaret.cpp
+++ b/layout/base/AccessibleCaret.cpp
@@ -387,15 +387,15 @@ AccessibleCaret::SetSelectionBarElementS
 }
 
 float
 AccessibleCaret::GetZoomLevel()
 {
   // Full zoom on desktop.
   float fullZoom = mPresShell->GetPresContext()->GetFullZoom();
 
-  // Pinch-zoom on B2G or fennec.
+  // Pinch-zoom on fennec.
   float resolution = mPresShell->GetCumulativeResolution();
 
   return fullZoom * resolution;
 }
 
 } // namespace mozilla
--- a/layout/base/gtest/TestAccessibleCaretManager.cpp
+++ b/layout/base/gtest/TestAccessibleCaretManager.cpp
@@ -345,17 +345,17 @@ TEST_F(AccessibleCaretManagerTester, Tes
   EXPECT_EQ(FirstCaretAppearance(), Appearance::None);
 
   mManager.OnScrollPositionChanged();
   EXPECT_EQ(FirstCaretAppearance(), Appearance::None);
 }
 
 TEST_F(AccessibleCaretManagerTester, TestScrollInSelectionMode)
 {
-  // Simulate B2G preference.
+  // Simulate caret hiding when scrolling.
   AutoRestore<bool> savesCaretsAlwaysShowWhenScrolling(
     MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling);
   MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling = false;
 
   EXPECT_CALL(mManager, GetCaretMode())
     .WillRepeatedly(Return(CaretMode::Selection));
 
   MockFunction<void(std::string aCheckPointName)> check;
@@ -529,17 +529,17 @@ TEST_F(AccessibleCaretManagerTester, Tes
   mManager.OnScrollEnd();
   EXPECT_EQ(FirstCaretAppearance(), Appearance::Left);
   EXPECT_EQ(SecondCaretAppearance(), Appearance::Right);
   check.Call("scrollend2");
 }
 
 TEST_F(AccessibleCaretManagerTester, TestScrollInCursorModeWhenLogicallyVisible)
 {
-  // Simulate B2G preference.
+  // Simulate caret hiding when scrolling.
   AutoRestore<bool> savesCaretsAlwaysShowWhenScrolling(
     MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling);
   MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling = false;
 
   EXPECT_CALL(mManager, GetCaretMode())
     .WillRepeatedly(Return(CaretMode::Cursor));
 
   EXPECT_CALL(mManager, HasNonEmptyTextContent(_))
@@ -594,17 +594,17 @@ TEST_F(AccessibleCaretManagerTester, Tes
 
   mManager.OnScrollEnd();
   EXPECT_EQ(FirstCaretAppearance(), Appearance::Normal);
   check.Call("scrollend2");
 }
 
 TEST_F(AccessibleCaretManagerTester, TestScrollInCursorModeWhenHidden)
 {
-  // Simulate B2G preference.
+  // Simulate caret hiding when scrolling.
   AutoRestore<bool> savesCaretsAlwaysShowWhenScrolling(
     MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling);
   MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling = false;
 
   EXPECT_CALL(mManager, GetCaretMode())
     .WillRepeatedly(Return(CaretMode::Cursor));
 
   EXPECT_CALL(mManager, HasNonEmptyTextContent(_))
@@ -653,17 +653,17 @@ TEST_F(AccessibleCaretManagerTester, Tes
 
   mManager.OnScrollEnd();
   EXPECT_EQ(FirstCaretAppearance(), Appearance::None);
   check.Call("scrollend2");
 }
 
 TEST_F(AccessibleCaretManagerTester, TestScrollInCursorModeOnEmptyContent)
 {
-  // Simulate B2G preference.
+  // Simulate caret hiding when scrolling.
   AutoRestore<bool> savesCaretsAlwaysShowWhenScrolling(
     MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling);
   MockAccessibleCaretManager::sCaretsAlwaysShowWhenScrolling = false;
 
   EXPECT_CALL(mManager, GetCaretMode())
     .WillRepeatedly(Return(CaretMode::Cursor));
 
   EXPECT_CALL(mManager, HasNonEmptyTextContent(_))