Bug 385189 - mac builds without libxul failing to compile due to macmorefiles, r=mento
authorbenjamin@smedbergs.us
Wed, 20 Jun 2007 12:22:01 -0700
changeset 2613 bfc7adc1abb028d54bb29e6580f9ff767301e1a9
parent 2612 81086fdd14a4fd1f85596815149be31dc92a540d
child 2614 93c50299f1be12d08f214d02abca9749b84c4132
push id1
push userbsmedberg@mozilla.com
push dateThu, 20 Mar 2008 16:49:24 +0000
treeherdermozilla-central@61007906a1f8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmento
bugs385189
milestone1.9a6pre
Bug 385189 - mac builds without libxul failing to compile due to macmorefiles, r=mento
modules/libreg/src/Makefile.in
xpcom/build/Makefile.in
xpinstall/src/Makefile.in
--- a/modules/libreg/src/Makefile.in
+++ b/modules/libreg/src/Makefile.in
@@ -62,16 +62,20 @@ FORCE_STATIC_LIB = 1
 # Force use of PIC
 FORCE_USE_PIC	= 1
 
 # We do want this in the static libraries list
 EXPORT_LIBRARY = 1
 
 USE_STATIC_LIBS = 1
 
+ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT))
+SHARED_LIBRARY_LIBS += $(DEPTH)/xpcom/MoreFiles/libmacmorefiles_s.a
+endif
+
 include $(topsrcdir)/config/config.mk
 
 DEFINES         += -DUSE_BUFFERED_REGISTRY_IO	
 # Memory mapped files are not supported under QNX, Neutrino, HP-UX and BeOS
 #ifeq (,$(filter BeOS HP-UX QNX,$(OS_ARCH)))
 #CSRCS		+= mmapio.c
 #DEFINES		+= -DUSE_MMAP_REGISTRY_IO
 #endif
--- a/xpcom/build/Makefile.in
+++ b/xpcom/build/Makefile.in
@@ -141,21 +141,16 @@ SDK_HEADERS =  \
 		nsXPCOM.h       \
 		nsXPCOMCID.h    \
 		$(NULL)
 
 EXPORTS	= \
 		nsXPCOMCIDInternal.h \
 		$(NULL)
 
-# pull in MoreFiles for MacOSX
-ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
-SHARED_LIBRARY_LIBS += ../MoreFiles/$(LIB_PREFIX)macmorefiles_s.$(LIB_SUFFIX)
-endif
-
 # Force use of PIC
 FORCE_USE_PIC	= 1 
 
 ifndef MOZ_ENABLE_LIBXUL
 ifndef MINIMO
 FORCE_SHARED_LIB = 1
 endif
 endif
@@ -176,17 +171,20 @@ DEFINES		+= \
 EXTRA_DSO_LDOPTS += $(NSPR_LIBS)
 
 ifdef GC_LEAK_DETECTOR
 DEFINES += -DGC_LEAK_DETECTOR
 endif
 
 ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
 CXXFLAGS	+= $(TK_CFLAGS)
-EXTRA_DSO_LDOPTS += $(TK_LIBS)
+EXTRA_DSO_LDOPTS += \
+  ../MoreFiles/$(LIB_PREFIX)macmorefiles_s.$(LIB_SUFFIX) \
+  $(TK_LIBS) \
+  $(NULL)
 endif
 
 ifeq ($(OS_ARCH),BeOS)
 EXTRA_DSO_LDOPTS += -lbe
 endif
 
 ifeq ($(OS_ARCH),WINNT)
 EXTRA_DSO_LDOPTS += $(call EXPAND_LIBNAME,shell32 ole32 uuid version)
--- a/xpinstall/src/Makefile.in
+++ b/xpinstall/src/Makefile.in
@@ -154,17 +154,16 @@ EXTRA_DSO_LDOPTS = \
 		$(MOZ_JS_LIBS) \
 		$(MOZ_UNICHARUTIL_LIBS) \
 		$(MOZ_COMPONENT_LIBS) \
 		$(ZLIB_LIBS) \
 		$(NULL)
 
 ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
 EXTRA_DSO_LDOPTS += \
-	$(DEPTH)/xpcom/MoreFiles/libmacmorefiles_s.a \
 	$(TK_LIBS) \
 	$(NULL)
 endif
 
 include $(topsrcdir)/config/rules.mk
 
 ifeq ($(OS_ARCH)$(MOZ_ENABLE_LIBXUL),WINNT)
 DEFINES		+= -DZLIB_DLL