Bug 864535. Drop some comments from WebIDL proxy [[Delete]] implementations, since the spec has changed. r=waldo
authorBoris Zbarsky <bzbarsky@mit.edu>
Wed, 24 Apr 2013 14:59:14 -0400
changeset 129785 be8219e1ae5f
parent 129784 c6a0fd976a43
child 129786 96803f97e1ee
push id24588
push userryanvm@gmail.com
push date2013-04-25 01:49 +0000
treeherdermozilla-central@690b5e0f6562 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerswaldo
bugs864535
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 864535. Drop some comments from WebIDL proxy [[Delete]] implementations, since the spec has changed. r=waldo
dom/bindings/Codegen.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -6464,27 +6464,25 @@ class CGDOMJSProxyHandler_delete(ClassMe
             deleter = self.descriptor.operations[type + 'Deleter']
             if deleter:
                 if (not deleter.signatures()[0][0].isPrimitive() or
                     deleter.signatures()[0][0].nullable() or
                     deleter.signatures()[0][0].tag() != IDLType.Tags.bool):
                     setBp = "*bp = true;"
                 else:
                     setBp = ("if (found) {\n"
-                             "  // XXXbz we should throw as needed if Throw is true\n"
                              "  *bp = result;\n"
                              "} else {\n"
                              "  *bp = true;\n"
                              "}")
                 body = (eval("CGProxy%sDeleter" % type)(self.descriptor).define() +
                         setBp)
             elif eval("self.descriptor.supports%sProperties()" % type):
                 body = (eval("CGProxy%sPresenceChecker" % type)(self.descriptor).define() +
                         "if (found) {\n"
-                        "  // XXXbz we should throw if Throw is true!\n"
                         "  *bp = false;\n"
                         "} else {\n"
                         "  *bp = true;\n"
                         "}")
             else:
                 body = None
             return body
 
@@ -6503,17 +6501,16 @@ class CGDOMJSProxyHandler_delete(ClassMe
                        "}\n") % self.descriptor.nativeType
 
         if UseHolderForUnforgeable(self.descriptor):
             unforgeable = ("JSBool hasUnforgeable;\n"
                            "if (!JS_HasPropertyById(cx, ${holder}, id, &hasUnforgeable)) {\n"
                            "  return false;\n"
                            "}\n"
                            "if (hasUnforgeable) {\n"
-                           "  // We should throw if Throw is true!\n"
                            "  *bp = false;\n"
                            "  return true;\n"
                            "}")
             delete += CallOnUnforgeableHolder(self.descriptor, unforgeable)
             delete += "\n"
 
         namedBody = getDeleterBody("Named")
         if namedBody is not None: