Bug 436685. FeedConverter does not need canConvert. r=gavin
authorSylvain Pasche <sylvain.pasche@gmail.com>
Mon, 06 Apr 2009 12:28:17 +1200
changeset 26948 be59cbdb5a92d46ead3e46b401fa1909f7bd8540
parent 26947 7c809460ad13286758748f2a1b8909b675d31126
child 26949 e6812f79d2ba827f76610965a93bfa649dc03cc7
push id6316
push userrocallahan@mozilla.com
push dateMon, 06 Apr 2009 01:20:36 +0000
treeherdermozilla-central@665b0bccbcf1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgavin
bugs436685
milestone1.9.2a1pre
Bug 436685. FeedConverter does not need canConvert. r=gavin
browser/components/feeds/src/FeedConverter.js
--- a/browser/components/feeds/src/FeedConverter.js
+++ b/browser/components/feeds/src/FeedConverter.js
@@ -156,27 +156,17 @@ FeedConverter.prototype = {
    * docshell for the load.
    */
   _listener: null,
 
   /**
    * Records if the feed was sniffed
    */
   _sniffed: false,
-  
-  /**
-   * See nsIStreamConverter.idl
-   */
-  canConvert: function FC_canConvert(sourceType, destinationType) {
-    // We only support one conversion.
-    return destinationType == TYPE_ANY && ((sourceType == TYPE_MAYBE_FEED) ||
-                                           (sourceType == TYPE_MAYBE_VIDEO) ||
-                                           (sourceType == TYPE_MAYBE_AUDIO));
-  },
-  
+
   /**
    * See nsIStreamConverter.idl
    */
   convert: function FC_convert(sourceStream, sourceType, destinationType, 
                                context) {
     throw Cr.NS_ERROR_NOT_IMPLEMENTED;
   },
   
@@ -357,17 +347,17 @@ FeedConverter.prototype = {
     this._processor.parseAsync(null, channel.URI);
     
     this._processor.onStartRequest(request, context);
   },
   
   /**
    * See nsIRequestObserver.idl
    */
-  onStopRequest: function FC_onStopReqeust(request, context, status) {
+  onStopRequest: function FC_onStopRequest(request, context, status) {
     if (this._processor)
       this._processor.onStopRequest(request, context, status);
   },
   
   /**
    * See nsISupports.idl
    */
   QueryInterface: function FC_QueryInterface(iid) {