Mercurial > mozilla-central / changeset / be57b9c18a09b2b00baa685716f4244b48c2153b
summary | shortlog | changelog | pushlog | graph | tags | bookmarks | branches | files | changeset | raw | zip | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Bug 1523562 [wpt PR 14781] - [css-grid] Let abspos items reference implicit grid lines, a=testonly
authorOriol Brufau <obrufau@igalia.com>
Thu, 31 Jan 2019 18:29:50 +0000
changeset 457932 be57b9c18a09b2b00baa685716f4244b48c2153b
parent 457931 e9480a6500a706d15e1f7beec3467bd2becaa1c3
child 457933 2e1b2bb1487697b0d04e8dc7a44a612619632803
push id35518
push useropoprus@mozilla.com
push dateFri, 08 Feb 2019 09:55:14 +0000
treeherdermozilla-central@3a3e393396f4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1523562, 14781, 915551, 1403656, 621556
milestone67.0a1
first release with
nightly linux32
3a3e393396f4 / 67.0a1 / 20190208095514 / files
nightly linux64
3a3e393396f4 / 67.0a1 / 20190208095514 / files
nightly mac
3a3e393396f4 / 67.0a1 / 20190208095514 / files
nightly win32
3a3e393396f4 / 67.0a1 / 20190208095514 / files
nightly win64
3a3e393396f4 / 67.0a1 / 20190208095514 / files
last release without
nightly linux32
4e98200ee530 / 67.0a1 / 20190207214423 / files
nightly linux64
4e98200ee530 / 67.0a1 / 20190207214423 / files
nightly mac
4e98200ee530 / 67.0a1 / 20190207214423 / files
nightly win32
4e98200ee530 / 67.0a1 / 20190207214423 / files
nightly win64
4e98200ee530 / 67.0a1 / 20190207214423 / files
Bug 1523562 [wpt PR 14781] - [css-grid] Let abspos items reference implicit grid lines, a=testonly Automatic update from web-platform-tests [css-grid] Let abspos items reference implicit grid lines While they can't create new implicit grid lines, abspos items can reference existing ones as clarified in https://github.com/w3c/csswg-drafts/commit/511bb63 This patch makes Blink match Firefox and Edge. Spec: https://drafts.csswg.org/css-grid/#abspos-items BUG=915551 TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-padding-001.html TEST=external/wpt/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html Change-Id: Ib363d6cc5c4ec9cc584ebd4a86c33719cea9f54c Reviewed-on: https://chromium-review.googlesource.com/c/1403656 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#621556} -- wpt-commits: 4f827364098d2b2b0b04ff3f9d5abd62582977c5 wpt-pr: 14781
testing/web-platform/tests/css/css-grid/abspos/grid-positioned-items-padding-001.html file | annotate | diff | comparison | revisions
testing/web-platform/tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html file | annotate | diff | comparison | revisions 
--- a/testing/web-platform/tests/css/css-grid/abspos/grid-positioned-items-padding-001.html
+++ b/testing/web-platform/tests/css/css-grid/abspos/grid-positioned-items-padding-001.html
@@ -104,23 +104,23 @@
   </div>
   <div class="absolute" style="grid-column: 3 / span 2; grid-row: 2 / 3;"
     data-offset-x="315" data-offset-y="65" data-expected-width="215" data-expected-height="150">
   </div>
 </div>
 
 <div class="grid">
   <div class="absolute" style="grid-column: foo / 1; grid-row: foo / 1;"
-    data-offset-x="0" data-offset-y="0" data-expected-width="15" data-expected-height="15">
+    data-offset-x="15" data-offset-y="15" data-expected-width="515" data-expected-height="315">
   </div>
   <div class="absolute" style="grid-column: 1 / 2; grid-row: foo / 1;"
-    data-offset-x="15" data-offset-y="0" data-expected-width="100" data-expected-height="15">
+    data-offset-x="15" data-offset-y="15" data-expected-width="100" data-expected-height="315">
   </div>
   <div class="absolute" style="grid-column: foo / 1; grid-row: 1 / 2;"
-    data-offset-x="0" data-offset-y="15" data-expected-width="15" data-expected-height="50">
+    data-offset-x="15" data-offset-y="15" data-expected-width="515" data-expected-height="50">
   </div>
   <div class="absolute" style="grid-column: 3 / foo; grid-row: 3 / foo;"
     data-offset-x="315" data-offset-y="215" data-expected-width="215" data-expected-height="115">
   </div>
   <div class="absolute" style="grid-column: 2 / 3; grid-row: 3 / foo;"
     data-offset-x="115" data-offset-y="215" data-expected-width="200" data-expected-height="115">
   </div>
   <div class="absolute" style="grid-column: 3 / foo; grid-row: 2 / 3;"
@@ -188,23 +188,23 @@
   </div>
   <div class="absolute" style="grid-column: 3 / span 2; grid-row: 2 / 3;"
     data-offset-x="0" data-offset-y="65" data-expected-width="215" data-expected-height="150">
   </div>
 </div>
 
 <div class="grid directionRTL">
   <div class="absolute" style="grid-column: foo / 1; grid-row: foo / 1;"
-    data-offset-x="515" data-offset-y="0" data-expected-width="15" data-expected-height="15">
+    data-offset-x="0" data-offset-y="15" data-expected-width="515" data-expected-height="315">
   </div>
   <div class="absolute" style="grid-column: 1 / 2; grid-row: foo / 1;"
-    data-offset-x="415" data-offset-y="0" data-expected-width="100" data-expected-height="15">
+    data-offset-x="415" data-offset-y="15" data-expected-width="100" data-expected-height="315">
   </div>
   <div class="absolute" style="grid-column: foo / 1; grid-row: 1 / 2;"
-    data-offset-x="515" data-offset-y="15" data-expected-width="15" data-expected-height="50">
+    data-offset-x="0" data-offset-y="15" data-expected-width="515" data-expected-height="50">
   </div>
   <div class="absolute" style="grid-column: 3 / foo; grid-row: 3 / foo;"
     data-offset-x="0" data-offset-y="215" data-expected-width="215" data-expected-height="115">
   </div>
   <div class="absolute" style="grid-column: 2 / 3; grid-row: 3 / foo;"
     data-offset-x="215" data-offset-y="215" data-expected-width="200" data-expected-height="115">
   </div>
   <div class="absolute" style="grid-column: 3 / foo; grid-row: 2 / 3;"
--- a/testing/web-platform/tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html
+++ b/testing/web-platform/tests/css/css-grid/abspos/grid-positioned-items-unknown-named-grid-line-001.html
@@ -1,14 +1,14 @@
 <!DOCTYPE html>
 <meta charset="utf-8">
 <title>CSS Grid Layout Test: Grid positioned items unknown named grid line</title>
 <link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <link rel="help" href="https://drafts.csswg.org/css-grid-1/#abspos" title="9. Absolute Positioning">
-<meta name="assert" content="This test checks that grid placement properties of absolutely positioned items using unknown named grid lines are treated as 'auto'.">
+<meta name="assert" content="This test checks that grid placement properties of absolutely positioned items can reference implicit grid lines.">
 <link rel="stylesheet" href="support/grid.css">
 <style>
 
 .grid {
   grid-template-columns: 100px 200px;
   grid-template-rows: 50px 150px;
   width: 500px;
   height: 300px;
@@ -53,25 +53,25 @@
 <div class="grid">
   <div class="absolute sizedToGridArea startAndEndUnknownLines"
     data-offset-x="0" data-offset-y="0" data-expected-width="530" data-expected-height="330">
   </div>
   <div class="absolute sizedToGridArea endUnknownLine"
     data-offset-x="15" data-offset-y="15" data-expected-width="515" data-expected-height="315">
   </div>
   <div class="absolute sizedToGridArea startUnknownLine"
-    data-offset-x="0" data-offset-y="0" data-expected-width="315" data-expected-height="215">
+    data-offset-x="315" data-offset-y="215" data-expected-width="215" data-expected-height="115">
   </div>
 </div>
 
 <div class="grid directionRTL">
   <div class="absolute sizedToGridArea startAndEndUnknownLines"
     data-offset-x="0" data-offset-y="0" data-expected-width="530" data-expected-height="330">
   </div>
   <div class="absolute sizedToGridArea endUnknownLine"
     data-offset-x="0" data-offset-y="15" data-expected-width="515" data-expected-height="315">
   </div>
   <div class="absolute sizedToGridArea startUnknownLine"
-    data-offset-x="215" data-offset-y="0" data-expected-width="315" data-expected-height="215">
+    data-offset-x="0" data-offset-y="215" data-expected-width="215" data-expected-height="115">
   </div>
 </div>
 
 </body>
mozilla-central
Deployed from b45e317b5917 at 2019-11-28T21:00:07Z.