Bug 1521249 part 0 - Remove Rust version cap from --enable-rust-simd. r=glandium
authorHenri Sivonen <hsivonen@hsivonen.fi>
Sat, 23 Mar 2019 14:17:35 +0000
changeset 465891 be4f4ec91925f3eff135c2a6e3c3a3eeffd59462
parent 465890 20f26343fafef69fc9f6f3f37cf984432da290bd
child 465892 d3d185b3c08554f9ebdb0410d3be4b4fa15477d7
push id35753
push useraiakab@mozilla.com
push dateMon, 25 Mar 2019 15:52:30 +0000
treeherdermozilla-central@df3fda80bbeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1521249
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521249 part 0 - Remove Rust version cap from --enable-rust-simd. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D21891
toolkit/moz.configure
--- a/toolkit/moz.configure
+++ b/toolkit/moz.configure
@@ -711,24 +711,21 @@ set_define('MOZ_BUILD_WEBRENDER', webren
 set_config('MOZ_ENABLE_WEBRENDER', webrender.enable)
 
 # SIMD acceleration for Rust code (currently just encoding_rs)
 # ==============================================================
 
 option('--enable-rust-simd', env='MOZ_RUST_SIMD',
        help='Enable explicit SIMD in Rust code.')
 
-@depends('--enable-rust-simd', target, rustc_info)
-def rust_simd(value, target, rustc_info):
-    # As of 2018-06-05, the simd crate only works on aarch64,
-    # armv7, x86 and x86_64.
+@depends('--enable-rust-simd', target)
+def rust_simd(value, target):
+    # As of 2019-03-04, the simd-accel feature of encoding_rs has not
+    # been properly set up outside aarch64, armv7, x86 and x86_64.
     if target.cpu in ('aarch64', 'arm', 'x86', 'x86_64') and value:
-        if rustc_info and rustc_info.version >= Version('1.33.0'):
-            die('--enable-rust-simd does not work with Rust 1.33 or later. '
-                'See https://bugzilla.mozilla.org/show_bug.cgi?id=1521249 .')
         return True
 
 set_config('MOZ_RUST_SIMD', rust_simd)
 set_define('MOZ_RUST_SIMD', rust_simd)
 
 # Printing
 # ==============================================================
 @depends(target)