Bug 1560777 - followup: Servo doesn't implement white-space: break-spaces.
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 23 Jun 2019 14:34:45 +0200
changeset 479893 bd23c45f9fe40beca6febd903b23879776b88e33
parent 479892 4ed761cebb7f768a44beebca0069fb3320a05018
child 479894 5be8ef19ca925970f946a6afb453ff6f4c8bf852
push id36189
push usercbrindusan@mozilla.com
push dateSun, 23 Jun 2019 21:47:52 +0000
treeherdermozilla-central@303b1fcafdeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1560777
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1560777 - followup: Servo doesn't implement white-space: break-spaces.
servo/components/style/properties/longhands/inherited_text.mako.rs
--- a/servo/components/style/properties/longhands/inherited_text.mako.rs
+++ b/servo/components/style/properties/longhands/inherited_text.mako.rs
@@ -170,58 +170,55 @@
     animation_value_type="ComputedValue",
     flags="APPLIES_TO_FIRST_LETTER APPLIES_TO_FIRST_LINE APPLIES_TO_PLACEHOLDER",
     spec="https://drafts.csswg.org/css-text/#propdef-word-spacing",
     servo_restyle_damage="rebuild_and_reflow",
 )}
 
 <%helpers:single_keyword
     name="white-space"
-    values="normal pre nowrap pre-wrap pre-line break-spaces"
-    extra_gecko_values="-moz-pre-space"
+    values="normal pre nowrap pre-wrap pre-line"
+    extra_gecko_values="break-spaces -moz-pre-space"
     gecko_enum_prefix="StyleWhiteSpace"
     needs_conversion="True"
     animation_value_type="discrete"
     // Only allowed for UA sheets, which set it !important.
     flags="APPLIES_TO_PLACEHOLDER"
     spec="https://drafts.csswg.org/css-text/#propdef-white-space"
     servo_restyle_damage="rebuild_and_reflow"
 >
     % if product != "gecko":
     impl SpecifiedValue {
         pub fn allow_wrap(&self) -> bool {
             match *self {
                 SpecifiedValue::Nowrap |
                 SpecifiedValue::Pre => false,
                 SpecifiedValue::Normal |
                 SpecifiedValue::PreWrap |
-                SpecifiedValue::PreLine |
-                SpecifiedValue::BreakSpaces => true,
+                SpecifiedValue::PreLine => true,
             }
         }
 
         pub fn preserve_newlines(&self) -> bool {
             match *self {
                 SpecifiedValue::Normal |
                 SpecifiedValue::Nowrap => false,
                 SpecifiedValue::Pre |
                 SpecifiedValue::PreWrap |
-                SpecifiedValue::PreLine |
-                SpecifiedValue::BreakSpaces => true,
+                SpecifiedValue::PreLine => true,
             }
         }
 
         pub fn preserve_spaces(&self) -> bool {
             match *self {
                 SpecifiedValue::Normal |
                 SpecifiedValue::Nowrap |
                 SpecifiedValue::PreLine => false,
                 SpecifiedValue::Pre |
-                SpecifiedValue::PreWrap |
-                SpecifiedValue::BreakSpaces => true,
+                SpecifiedValue::PreWrap => true,
             }
         }
     }
     % endif
 </%helpers:single_keyword>
 
 ${helpers.predefined_type(
     "text-shadow",