Bug 1552987 - Jump-to-function-definition buttons are no longer visible in the console. r=nchevobbe
authorJason Laster <jlaster@mozilla.com>
Tue, 21 May 2019 16:54:56 +0000
changeset 474780 bd089729aaeaea30cb38a4d8c4895690a009e07a
parent 474779 f5ae6a49e7911e869c0d003ad725e5c34a765f33
child 474781 d30842e4cfea49c26c260b3d00355362a680cd13
push id36046
push useraiakab@mozilla.com
push dateTue, 21 May 2019 21:45:52 +0000
treeherdermozilla-central@257f2c96cef5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1552987
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552987 - Jump-to-function-definition buttons are no longer visible in the console. r=nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D32003
devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.css
devtools/client/debugger/packages/devtools-reps/src/reps/reps.css
devtools/client/shared/components/reps/reps.css
--- a/devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.css
+++ b/devtools/client/debugger/packages/devtools-reps/src/object-inspector/components/ObjectInspector.css
@@ -46,13 +46,12 @@
   margin-inline-start: -1px;
 }
 
 /* Focused styles */
 .tree.object-inspector .tree-node.focused * {
   color: inherit;
 }
 
-.tree-node.focused button.jump-definition,
 .tree-node.focused button.open-inspector,
 .tree-node.focused button.invoke-getter {
   background-color: currentColor;
 }
--- a/devtools/client/debugger/packages/devtools-reps/src/reps/reps.css
+++ b/devtools/client/debugger/packages/devtools-reps/src/reps/reps.css
@@ -263,27 +263,35 @@ button.open-inspector {
 .open-inspector:hover {
   background-color: var(--theme-icon-checked-color);
 }
 
 /******************************************************************************/
 /* Jump to definition button */
 
 button.jump-definition {
-  mask: url(resource://devtools/client/shared/components/reps/images/jump-definition.svg)
-    no-repeat;
   display: inline-block;
-  background-color: var(--theme-icon-color);
   height: 16px;
   margin-left: 0.25em;
   vertical-align: middle;
+  background: 0% 50%
+    url("resource://devtools/client/shared/components/reps/images/jump-definition.svg")
+    no-repeat;
+  border-color: transparent;
+  stroke: var(--theme-icon-color);
+  -moz-context-properties: stroke;
+  cursor: pointer;
 }
 
 .jump-definition:hover {
-  background-color: var(--theme-icon-checked-color);
+  stroke: var(--theme-icon-checked-color);
+}
+
+.tree-node.focused .jump-definition {
+  stroke: currentColor;
 }
 
 /******************************************************************************/
 /* Invoke getter button */
 
 button.invoke-getter {
   mask: url(resource://devtools/client/shared/components/reps/images/input.svg)
     no-repeat;
--- a/devtools/client/shared/components/reps/reps.css
+++ b/devtools/client/shared/components/reps/reps.css
@@ -358,27 +358,35 @@ button.open-inspector {
 .open-inspector:hover {
   background-color: var(--theme-icon-checked-color);
 }
 
 /******************************************************************************/
 /* Jump to definition button */
 
 button.jump-definition {
-  mask: url("resource://devtools/client/shared/components/reps/images/jump-definition.svg")
-    no-repeat;
   display: inline-block;
-  background-color: var(--theme-icon-color);
   height: 16px;
   margin-left: 0.25em;
   vertical-align: middle;
+  background: 0% 50%
+    url("resource://devtools/client/shared/components/reps/images/jump-definition.svg")
+    no-repeat;
+  border-color: transparent;
+  stroke: var(--theme-icon-color);
+  -moz-context-properties: stroke;
+  cursor: pointer;
 }
 
 .jump-definition:hover {
-  background-color: var(--theme-icon-checked-color);
+  stroke: var(--theme-icon-checked-color);
+}
+
+.tree-node.focused .jump-definition {
+  stroke: currentColor;
 }
 
 /******************************************************************************/
 /* Invoke getter button */
 
 button.invoke-getter {
   mask: url("resource://devtools/client/shared/components/reps/images/input.svg")
     no-repeat;
@@ -446,13 +454,12 @@ button.invoke-getter {
   margin-inline-start: -1px;
 }
 
 /* Focused styles */
 .tree.object-inspector .tree-node.focused * {
   color: inherit;
 }
 
-.tree-node.focused button.jump-definition,
 .tree-node.focused button.open-inspector,
 .tree-node.focused button.invoke-getter {
   background-color: currentColor;
 }