Bug 562508 - Submitted comparison between signed and unsigned integer expressions in nsOggPlayStateMachine::Run(). r=doublec
authortimeless@mozdev.org
Fri, 30 Apr 2010 15:04:12 +1200
changeset 41618 bd072ff095af
parent 41617 8eb00d668f61
child 41619 d349761ddc1e
push id13067
push usercpearce@mozilla.com
push dateFri, 30 Apr 2010 03:14:50 +0000
treeherdermozilla-central@756f81db342b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdoublec
bugs562508
milestone1.9.3a5pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
Bug 562508 - Submitted comparison between signed and unsigned integer expressions in nsOggPlayStateMachine::Run(). r=doublec
content/media/ogg/nsOggPlayStateMachine.cpp
--- a/content/media/ogg/nsOggPlayStateMachine.cpp
+++ b/content/media/ogg/nsOggPlayStateMachine.cpp
@@ -762,17 +762,17 @@ nsresult nsOggPlayStateMachine::Run()
         if (mState != DECODER_STATE_DECODING)
           continue;
 
         if (mBufferExhausted &&
             mDecoder->GetState() == nsBuiltinDecoder::PLAY_STATE_PLAYING &&
             !mDecoder->GetCurrentStream()->IsDataCachedToEndOfStream(mDecoder->mDecoderPosition) &&
             !mDecoder->GetCurrentStream()->IsSuspendedByCache() &&
             ((HasAudio() && mReader->mAudioQueue.Duration() < LOW_AUDIO_MS) ||
-             (HasVideo() && mReader->mVideoQueue.GetSize() < LOW_VIDEO_FRAMES)))
+             (HasVideo() && (PRUint32)mReader->mVideoQueue.GetSize() < LOW_VIDEO_FRAMES)))
         {
           // There is at most one frame in the queue and there's
           // more data to load. Let's buffer to make sure we can play a
           // decent amount of video in the future.
           if (IsPlaying()) {
             StopPlayback(AUDIO_PAUSE);
             mDecoder->GetMonitor().NotifyAll();
           }