Bug 1639088 - Capitalize debugger settings menu items r=Harald,jlast
authorDavid Walsh <dwalsh@mozilla.com>
Wed, 20 May 2020 01:09:59 +0000
changeset 531250 bce461cdebb5b0676ef9df590bb6407aeae80c08
parent 531249 ae4bb7a34b7e61c612afe22703363b0d17b821f3
child 531251 4b9b959c1ef084147376f21f5514e400ffceb80d
push id37436
push userncsoregi@mozilla.com
push dateWed, 20 May 2020 21:30:50 +0000
treeherdermozilla-central@6c10970490f3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHarald, jlast
bugs1639088
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1639088 - Capitalize debugger settings menu items r=Harald,jlast Differential Revision: https://phabricator.services.mozilla.com/D75972
devtools/client/debugger/src/components/SecondaryPanes/CommandBar.js
devtools/client/locales/en-US/debugger.properties
--- a/devtools/client/debugger/src/components/SecondaryPanes/CommandBar.js
+++ b/devtools/client/debugger/src/components/SecondaryPanes/CommandBar.js
@@ -262,28 +262,28 @@ class CommandBar extends Component<Props
           label={L10N.getStr("settings.disableJavaScript.label")}
           tooltip={L10N.getStr("settings.disableJavaScript.tooltip")}
           onClick={() => {
             javascriptPrefs.enableJavaScript = !javascriptPrefs.enableJavaScript;
           }}
         />
         <MenuItem
           key="debugger-settings-menu-item-disable-inline-previews"
-          checked={!features.inlinePreview}
-          label={L10N.getStr("inlinePreview.disable.label")}
-          tooltip={L10N.getStr("inlinePreview.disable.tooltip")}
+          checked={features.inlinePreview}
+          label={L10N.getStr("inlinePreview.toggle.label")}
+          tooltip={L10N.getStr("inlinePreview.toggle.tooltip")}
           onClick={() =>
             this.props.toggleInlinePreview(!features.inlinePreview)
           }
         />
         <MenuItem
           key="debugger-settings-menu-item-disable-sourcemaps"
-          checked={!prefs.clientSourceMapsEnabled}
-          label={L10N.getStr("settings.disableSourceMaps.label")}
-          tooltip={L10N.getStr("settings.disableSourceMaps.tooltip")}
+          checked={prefs.clientSourceMapsEnabled}
+          label={L10N.getStr("settings.toggleSourceMaps.label")}
+          tooltip={L10N.getStr("settings.toggleSourceMaps.tooltip")}
           onClick={() =>
             this.props.toggleSourceMapsEnabled(!prefs.clientSourceMapsEnabled)
           }
         />
       </MenuList>
     );
   }
 
--- a/devtools/client/locales/en-US/debugger.properties
+++ b/devtools/client/locales/en-US/debugger.properties
@@ -474,42 +474,42 @@ downloadFile.accesskey=d
 # LOCALIZATION NOTE (inlinePreview.show.label): Context menu item
 # for showing the inline preview blocks
 inlinePreview.show.label=Show inline preview
 
 # LOCALIZATION NOTE (inlinePreview.hide.label): Context menu item
 # for hiding the inline preview block
 inlinePreview.hide.label=Hide inline preview
 
-# LOCALIZATION NOTE (inlinePreview.disable.label): Context menu item
+# LOCALIZATION NOTE (inlinePreview.toggle.label): Context menu item
 # that will toggle display of inline preview
-inlinePreview.disable.label=Disable inline preview
+inlinePreview.toggle.label=Inline Variable Preview
 
-# LOCALIZATION NOTE (inlinePreview.disable.tooltip): Context menu item
-# tooltip that will describe disabling inline preview
-inlinePreview.disable.tooltip=Disables inline preview in the debugger editor
+# LOCALIZATION NOTE (inlinePreview.toggle.tooltip): Context menu item
+# tooltip that will describe toggling inline preview
+inlinePreview.toggle.tooltip=Show inline preview in the debugger editor
 
 # LOCALIZATION NOTE (settings.button.label): Label for Settings button
 settings.button.label=Debugger Settings
 
 # LOCALIZATION NOTE (settings.disableJavaScript.label): Context menu item
 # label for disabling JavaScript
 settings.disableJavaScript.label=Disable JavaScript
 
 # LOCALIZATION NOTE (settings.disableJavaScript.tooltip): Context menu item
 # tooltip for disabling JavaScript
 settings.disableJavaScript.tooltip=Disables JavaScript (Requires refresh)
 
-# LOCALIZATION NOTE (settings.disableSourceMaps.tooltip): Context menu item
-# tooltip for disabling source maps
-settings.disableSourceMaps.tooltip=Disables client source maps
+# LOCALIZATION NOTE (settings.toggleSourceMaps.tooltip): Context menu item
+# tooltip for toggling the source maps feature
+settings.toggleSourceMaps.tooltip=Enable Source Maps to let DevTools load your original sources in addition to your generated ones
 
-# LOCALIZATION NOTE (settings.disableSourceMaps.label): Context menu item
-# label for disabling source maps
-settings.disableSourceMaps.label=Disable source maps
+# LOCALIZATION NOTE (settings.toggleSourceMaps.label): Context menu item
+# label for toggling the source maps feature
+settings.toggleSourceMaps.label=Source Maps
 
 # LOCALIZATION NOTE (preview.noProperties): Label shown in the preview
 # popup when there are no properties to show.
 preview.noProperties=No properties
 
 # LOCALIZATION NOTE (framework.disableGrouping): This is the text that appears in the
 # context menu to disable framework grouping.
 framework.disableGrouping=Disable framework grouping