Bug 579517 - Remove some PRBools. r=ehsan
authorChris Peterson <cpeterson@mozilla.com>
Thu, 04 Apr 2013 10:28:18 -0700
changeset 127687 bc3f63dbba94dd4427b0e625dcf47ce076d45649
parent 127686 97d4b08ee4af69c159295967b28cf55d689beca9
child 127688 c4f46d70fa1c285f24f8b9f55dc3c318a3d09563
push id24509
push userryanvm@gmail.com
push dateFri, 05 Apr 2013 00:57:47 +0000
treeherdermozilla-central@55f9e3e3dae7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs579517
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 579517 - Remove some PRBools. r=ehsan
dom/src/geolocation/nsGeolocation.cpp
dom/src/geolocation/nsGeolocation.h
xpcom/threads/TimerThread.h
--- a/dom/src/geolocation/nsGeolocation.cpp
+++ b/dom/src/geolocation/nsGeolocation.cpp
@@ -862,17 +862,17 @@ nsGeolocationService::Update(nsIDOMGeoPo
   }
 
   for (uint32_t i = 0; i< mGeolocators.Length(); i++) {
     mGeolocators[i]->Update(aSomewhere, isBetter);
   }
   return NS_OK;
 }
 
-PRBool
+bool
 nsGeolocationService::IsBetterPosition(nsIDOMGeoPosition *aSomewhere)
 {
   if (!aSomewhere) {
     return false;
   }
 
   if (mProviders.Count() == 1 || !mLastPosition) {
     return true;
--- a/dom/src/geolocation/nsGeolocation.h
+++ b/dom/src/geolocation/nsGeolocation.h
@@ -119,17 +119,17 @@ public:
   void HandleMozsettingValue(const bool aValue);
 
   // Management of the nsGeolocation objects
   void AddLocator(nsGeolocation* locator);
   void RemoveLocator(nsGeolocation* locator);
 
   void SetCachedPosition(nsIDOMGeoPosition* aPosition);
   nsIDOMGeoPosition* GetCachedPosition();
-  PRBool IsBetterPosition(nsIDOMGeoPosition *aSomewhere);
+  bool IsBetterPosition(nsIDOMGeoPosition *aSomewhere);
 
   // Find and startup a geolocation device (gps, nmea, etc.)
   nsresult StartDevice(nsIPrincipal* aPrincipal, bool aRequestPrivate);
 
   // Stop the started geolocation device (gps, nmea, etc.)
   void     StopDevice();
 
   // create, or reinitalize the callback timer
--- a/xpcom/threads/TimerThread.h
+++ b/xpcom/threads/TimerThread.h
@@ -76,26 +76,26 @@ struct TimerAdditionComparator {
   TimerAdditionComparator(const mozilla::TimeStamp &aNow,
                           nsTimerImpl *aTimerToInsert) :
     now(aNow)
 #ifdef DEBUG
     , timerToInsert(aTimerToInsert)
 #endif
   {}
 
-  PRBool LessThan(nsTimerImpl *fromArray, nsTimerImpl *newTimer) const {
+  bool LessThan(nsTimerImpl *fromArray, nsTimerImpl *newTimer) const {
     NS_ABORT_IF_FALSE(newTimer == timerToInsert, "Unexpected timer ordering");
 
     // Skip any overdue timers.
     return fromArray->mTimeout <= now ||
            fromArray->mTimeout <= newTimer->mTimeout;
   }
 
-  PRBool Equals(nsTimerImpl* fromArray, nsTimerImpl* newTimer) const {
-    return PR_FALSE;
+  bool Equals(nsTimerImpl* fromArray, nsTimerImpl* newTimer) const {
+    return false;
   }
 
 private:
   const mozilla::TimeStamp &now;
 #ifdef DEBUG
   const nsTimerImpl * const timerToInsert;
 #endif
 };