Bug 1362165: P3. Remove unecessary code. r=gerald
authorJean-Yves Avenard <jyavenard@mozilla.com>
Fri, 28 Apr 2017 16:18:36 +0200
changeset 361278 bc1e56d5cb9ba2d563981973573cf3b10fc0abdb
parent 361277 c89c6c8630f132296b2e2edbba4239a8ad7a1075
child 361279 5334cc6d0ea9b47325f4d6fcf4dab59307d12d55
push id31924
push userryanvm@gmail.com
push dateTue, 30 May 2017 20:08:50 +0000
treeherdermozilla-central@692e277e2b9f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald
bugs1362165
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1362165: P3. Remove unecessary code. r=gerald We have no need to call endOfStream here as we don't rely on the ended event being fired. Also, there's no need to track how many update count we will get when we only use appendBuffer once. Adding extra test to help identify where the actual failure of the test could occur. MozReview-Commit-ID: HIu1XQpHark
dom/media/mediasource/test/test_BufferedSeek.html
dom/media/mediasource/test/test_BufferedSeek_mp4.html
--- a/dom/media/mediasource/test/test_BufferedSeek.html
+++ b/dom/media/mediasource/test/test_BufferedSeek.html
@@ -7,38 +7,28 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
 </head>
 <body>
 <pre id="test">
 <script class="testbody" type="text/javascript">
 
 SimpleTest.waitForExplicitFinish();
 
-var updateCount = 0;
-
 runWithMSE(function (ms, v) {
   ms.addEventListener("sourceopen", function () {
     var sb = ms.addSourceBuffer("video/webm");
 
     fetchWithXHR("seek.webm", function (arrayBuffer) {
       sb.appendBuffer(new Uint8Array(arrayBuffer));
-      sb.addEventListener("updateend", function () {
-        updateCount++;
-        /* Ensure that we endOfStream on the first update event only as endOfStream can
-           raise more if the duration of the last buffered range and the intial duration
-           differ. See bug 1065207 */
-        if (updateCount == 1) {
-          ms.endOfStream();
-        };
-      });
     });
 
     var target = 2;
 
     v.addEventListener("loadedmetadata", function () {
+      ok(true, "received loadedmetadata");
       v.currentTime = target;
     });
 
     var wasSeeking = false;
 
     v.addEventListener("seeking", function () {
       wasSeeking = true;
       is(v.currentTime, target, "Video currentTime at target");
--- a/dom/media/mediasource/test/test_BufferedSeek_mp4.html
+++ b/dom/media/mediasource/test/test_BufferedSeek_mp4.html
@@ -7,38 +7,28 @@
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
 </head>
 <body>
 <pre id="test">
 <script class="testbody" type="text/javascript">
 
 SimpleTest.waitForExplicitFinish();
 
-var updateCount = 0;
-
 runWithMSE(function (ms, v) {
   ms.addEventListener("sourceopen", function () {
     var sb = ms.addSourceBuffer("video/mp4");
 
     fetchWithXHR("bipbop/bipbop2s.mp4", function (arrayBuffer) {
       sb.appendBuffer(new Uint8Array(arrayBuffer));
-      sb.addEventListener("updateend", function () {
-        updateCount++;
-        /* Ensure that we endOfStream on the first update event only as endOfStream can
-           raise more if the duration of the last buffered range and the intial duration
-           differ. See bug 1065207 */
-        if (updateCount == 1) {
-          ms.endOfStream();
-        };
-      });
     });
 
     var target = 1.3;
 
     v.addEventListener("loadedmetadata", function () {
+      ok(true, "received loadedmetadata");
       v.currentTime = target;
     });
 
     var wasSeeking = false;
 
     v.addEventListener("seeking", function () {
       wasSeeking = true;
       is(v.currentTime, target, "Video currentTime at target");