mozilla-central: changeset 458185:bbc29fb3d0bf74fde45e99eb0a43b1f61551daa7

author	Ian Kilpatrick <ikilpatrick@chromium.org>
	Fri, 01 Feb 2019 13:40:56 +0000
changeset 458185	bbc29fb3d0bf74fde45e99eb0a43b1f61551daa7
parent 458184	34865e88897289c24a6cfd1a04fc3373d7bbebcb
child 458186	8458faca7e33dbc919ed65b29f4c4fc018ca91c0
push id	35518
push user	opoprus@mozilla.com
push date	Fri, 08 Feb 2019 09:55:14 +0000
treeherder	mozilla-central@3a3e393396f4 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	testonly
bugs	1523562, 15053, 924504, 1434919, 626650
milestone	67.0a1
first release with	nightly linux32 3a3e393396f4 / 67.0a1 / 20190208095514 / files nightly linux64 3a3e393396f4 / 67.0a1 / 20190208095514 / files nightly mac 3a3e393396f4 / 67.0a1 / 20190208095514 / files nightly win32 3a3e393396f4 / 67.0a1 / 20190208095514 / files nightly win64 3a3e393396f4 / 67.0a1 / 20190208095514 / files
last release without	nightly linux32 4e98200ee530 / 67.0a1 / 20190207214423 / files nightly linux64 4e98200ee530 / 67.0a1 / 20190207214423 / files nightly mac 4e98200ee530 / 67.0a1 / 20190207214423 / files nightly win32 4e98200ee530 / 67.0a1 / 20190207214423 / files nightly win64 4e98200ee530 / 67.0a1 / 20190207214423 / files

Bug 1523562 [wpt PR 15053] - [LayoutNG] Compute table cell margins to zero., a=testonly Automatic update from web-platform-tests [LayoutNG] Compute table cell margins to zero. In the bug we check when we are performing the layout overflow calculation if we have margins and add them if necessary. Because we were setting them in LayoutNG (and not in Legacy) it meant that we were contributing to overflow! This forces margins to compute to zero for table cells. Bug: 924504 Change-Id: Ia3595e0b432a965e7ed4bd28a8b3cf046fdf3775 Reviewed-on: https://chromium-review.googlesource.com/c/1434919 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#626650} -- wpt-commits: 48480234722c9e283c8c5457916db073a25d68cd wpt-pr: 15053

testing/web-platform/tests/css/css-tables/no-overflow-with-table-cell-margins.html

file | annotate | diff | comparison | revisions

new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-tables/no-overflow-with-table-cell-margins.html
@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<link rel="help" href="https://drafts.csswg.org/css-tables-3/">
+<meta name="assert" content="Table cell margins do not contribute to layout overflow.">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<style>
+html {
+  display: table;
+  width: 100%;
+  height: 100%;
+}
+body {
+  display: table-cell;
+  width: 100%;
+}
+</style>
+<body></body>
+<script>
+  test(() => {
+    const scroller = document.scrollingElement;
+
+    // There shouldn't be any layout overflow on the root scrollable element.
+    assert_equals(scroller.clientHeight, scroller.scrollHeight);
+  });
+</script>