Bug 1459988 - disallow MSVC 15.7+ from being used to build Firefox; r=ted.mielczarek
authorNathan Froyd <froydnj@mozilla.com>
Wed, 09 May 2018 17:26:32 -0400
changeset 417676 bb8e6bef734f562d70737964dd93f417f19e8c1c
parent 417675 d5b4c508bebde7ce98a9b8012d6806412159f2a1
child 417677 ed0bdeaa6fd4284bf48d9b055148ec0fe308cfcc
push id33977
push userncsoregi@mozilla.com
push dateThu, 10 May 2018 16:43:24 +0000
treeherdermozilla-central@17db33b6a124 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1459988
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1459988 - disallow MSVC 15.7+ from being used to build Firefox; r=ted.mielczarek
build/moz.configure/toolchain.configure
python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -912,17 +912,28 @@ def compiler(language, host_or_target, c
             raise FatalCheckError(
                 'Only clang/llvm 3.6 or newer is supported.')
 
         if info.type == 'msvc':
             if info.version < '19.13.26128':
                 raise FatalCheckError(
                     'This version (%s) of the MSVC compiler is not '
                     'supported.\n'
-                    'You must install Visual C++ 2017 Update 6 or newer in '
+                    'You must install Visual C++ 2017 Update 6 in '
+                    'order to build.\n'
+                    'See https://developer.mozilla.org/en/'
+                    'Windows_Build_Prerequisites' % info.version)
+
+            # MSVC version 15.7 and the previews for 15.8, at least,
+            # can't build Firefox.
+            if info.version >= '19.14.0':
+                raise FatalCheckError(
+                    'This version (%s) of the MSVC compiler is not '
+                    'supported due to compiler bugs.\n'
+                    'You must install Visual C++ 2017 Update 6 in '
                     'order to build.\n'
                     'See https://developer.mozilla.org/en/'
                     'Windows_Build_Prerequisites' % info.version)
 
         if info.flags:
             raise FatalCheckError(
                 'Unknown compiler or compiler not supported.')
 
--- a/python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py
+++ b/python/mozbuild/mozbuild/test/configure/test_toolchain_configure.py
@@ -882,41 +882,41 @@ class WindowsToolchainTest(BaseToolchain
         '/usr/bin/clang-3.6': CLANG_3_6 + CLANG_PLATFORM_X86_WIN,
         '/usr/bin/clang++-3.6': CLANGXX_3_6 + CLANG_PLATFORM_X86_WIN,
         '/usr/bin/clang-3.3': CLANG_3_3 + CLANG_PLATFORM_X86_WIN,
         '/usr/bin/clang++-3.3': CLANGXX_3_3 + CLANG_PLATFORM_X86_WIN,
     }
 
     VS_2013u2_RESULT = (
         'This version (18.00.30501) of the MSVC compiler is not supported.\n'
-        'You must install Visual C++ 2017 Update 6 or newer in order to build.\n'
+        'You must install Visual C++ 2017 Update 6 in order to build.\n'
         'See https://developer.mozilla.org/en/Windows_Build_Prerequisites')
     VS_2013u3_RESULT = (
         'This version (18.00.30723) of the MSVC compiler is not supported.\n'
-        'You must install Visual C++ 2017 Update 6 or newer in order to build.\n'
+        'You must install Visual C++ 2017 Update 6 in order to build.\n'
         'See https://developer.mozilla.org/en/Windows_Build_Prerequisites')
     VS_2015_RESULT = (
         'This version (19.00.23026) of the MSVC compiler is not supported.\n'
-        'You must install Visual C++ 2017 Update 6 or newer in order to build.\n'
+        'You must install Visual C++ 2017 Update 6 in order to build.\n'
         'See https://developer.mozilla.org/en/Windows_Build_Prerequisites')
     VS_2015u1_RESULT = (
         'This version (19.00.23506) of the MSVC compiler is not supported.\n'
-        'You must install Visual C++ 2017 Update 6 or newer in order to build.\n'
+        'You must install Visual C++ 2017 Update 6 in order to build.\n'
         'See https://developer.mozilla.org/en/Windows_Build_Prerequisites')
     VS_2015u2_RESULT = (
         'This version (19.00.23918) of the MSVC compiler is not supported.\n'
-        'You must install Visual C++ 2017 Update 6 or newer in order to build.\n'
+        'You must install Visual C++ 2017 Update 6 in order to build.\n'
         'See https://developer.mozilla.org/en/Windows_Build_Prerequisites')
     VS_2015u3_RESULT = (
         'This version (19.00.24213) of the MSVC compiler is not supported.\n'
-        'You must install Visual C++ 2017 Update 6 or newer in order to build.\n'
+        'You must install Visual C++ 2017 Update 6 in order to build.\n'
         'See https://developer.mozilla.org/en/Windows_Build_Prerequisites')
     VS_2017u4_RESULT = (
         'This version (19.11.25547) of the MSVC compiler is not supported.\n'
-        'You must install Visual C++ 2017 Update 6 or newer in order to build.\n'
+        'You must install Visual C++ 2017 Update 6 in order to build.\n'
         'See https://developer.mozilla.org/en/Windows_Build_Prerequisites')
     VS_2017u6_RESULT = CompilerResult(
         flags=[],
         version='19.13.26128',
         type='msvc',
         compiler='/usr/bin/cl',
         language='C',
     )