Bug 1319166 - Don't automatically enable color in iTerm2; r=glandium
authorGregory Szorc <gps@mozilla.com>
Mon, 21 Nov 2016 22:37:01 -0800
changeset 323773 bb32e325ac8e1acbdd108d2c190760d29081f96d
parent 323772 a6a09538a5949f39bfc06b5929ed6348a93fbfbc
child 323774 e241e4cec47a06af8d70054ccf2dddcd9b440d27
push id30982
push userphilringnalda@gmail.com
push dateWed, 23 Nov 2016 03:27:03 +0000
treeherdermozilla-central@90b691bf09f5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1319166
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1319166 - Don't automatically enable color in iTerm2; r=glandium iTerm2 interprets the byte sequence "ESC [ 2 i" as a request to open a print dialog. This sequence can get emitted when printing colorized compiler output. Until we figure out a workaround, disable automatic coloring on iTerm2 so developers aren't annoyed. MozReview-Commit-ID: 3Be4YgArg4k
config/config.mk
--- a/config/config.mk
+++ b/config/config.mk
@@ -356,19 +356,24 @@ color_flags_vars := \
   COMPILE_CMMFLAGS \
   HOST_CFLAGS \
   HOST_CXXFLAGS \
   LDFLAGS \
   $(NULL)
 
 ifdef MACH_STDOUT_ISATTY
 ifdef COLOR_CFLAGS
+# TODO Bug 1319166 - iTerm2 interprets some bytes  sequences as a
+# request to show a print dialog. Don't enable color on iTerm2 until
+# a workaround is in place.
+ifneq ($(TERM_PROGRAM),iTerm.app)
 $(foreach var,$(color_flags_vars),$(eval $(call colorize_flags,$(var))))
 endif
 endif
+endif
 
 #
 # Name of the binary code directories
 #
 # Override defaults
 
 SDK_LIB_DIR = $(DIST)/sdk/lib
 SDK_BIN_DIR = $(DIST)/sdk/bin