bug 1328964 add override to ~WorkletJSContext/Runtime and use = default r=baku
authorKarl Tomlinson <karlt+@karlt.net>
Tue, 27 Mar 2018 18:15:54 +1300
changeset 412953 bb29485e179b8dbbd42f0ae26f63d9ce173463b5
parent 412952 608bd57e774e5b1ee466c41ce7343d3282d75428
child 412954 c3c9f4525efb7898bab818432f44d9ee25ca4c11
push id33828
push userarchaeopteryx@coole-files.de
push dateThu, 12 Apr 2018 19:19:41 +0000
treeherdermozilla-central@6e22c4a726c2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1328964
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1328964 add override to ~WorkletJSContext/Runtime and use = default r=baku Addresses modernize-use-override and modernize-use-equals-default clang-tidy suggestions in "part 2 - Worklet Thread". MozReview-Commit-ID: H1a9kBCF1Q6
dom/worklet/WorkletThread.cpp
--- a/dom/worklet/WorkletThread.cpp
+++ b/dom/worklet/WorkletThread.cpp
@@ -105,19 +105,17 @@ const JSWrapObjectCallbacks WrapObjectCa
 class WorkletJSRuntime final : public mozilla::CycleCollectedJSRuntime
 {
 public:
   explicit WorkletJSRuntime(JSContext* aCx)
     : CycleCollectedJSRuntime(aCx)
   {
   }
 
-  ~WorkletJSRuntime()
-  {
-  }
+  ~WorkletJSRuntime() override = default;
 
   virtual void
   PrepareForForgetSkippable() override
   {
   }
 
   virtual void
   BeginCycleCollectionCallback() override
@@ -152,17 +150,17 @@ public:
     : mWorkletThread(aWorkletThread)
   {
     MOZ_ASSERT(aWorkletThread);
     MOZ_ASSERT(!NS_IsMainThread());
 
     nsCycleCollector_startup();
   }
 
-  ~WorkletJSContext()
+  ~WorkletJSContext() override
   {
     MOZ_ASSERT(!NS_IsMainThread());
 
     JSContext* cx = MaybeContext();
     if (!cx) {
       return;   // Initialize() must have failed
     }